Incompatible pointer to integer conversion warnings in LDUserModel.m #59
Comments
|
We'll look into this now :) thanks for pointing it out |
|
Thanks - I opened an almost duplicate issue against another file as well. We've got a zero new warnings policy on our build system and this and the other issue break us. |
|
No problem, we'll make these changes shortly |
markpokornycos
added a commit
that referenced
this issue
Mar 8, 2019
* renames schemes and targets to LaunchDarkly * renames test target and headers to LaunchDarkly * renames code and test folders to LaunchDarkly * renames xcode project to LaunchDarkly * renames workspace to LaunchDarkly * renames modules and sets Catamorphic Co as license holder in block header comment * renames podfile workspace and targets to LaunchDarkly * renames Jazzy components to LaunchDarkly * replaces outdated variable_name rule with identifier_name to clear swiftlint warnings * renames workspace and scheme to LaunchDarkly in circleCI * installs CocoaPods 1.6.0 * installs DarklyEventSource 4.0.1 * installs Quick 7.3.4 and Nimble 1.3.4 * installs SwiftLint 0.30.1 * Add instructions to integrate without a package manager (#57) * Replaces onServerUnavailable with ErrorObserver (#58) * Adds new logging around variationAndSource (#59) * Install keys to model objects (#60) * Adds Automated Tests for missing coverage (#61) * Decompress Blocks (#62) * Refine flag version handling (#63) * sets beta 3 version and updates public documents * Add Platform Names to non-iOS frameworks (#65) * renames all schemes, targets, and non-iOS products to include the platform * updates changelog and instructions for non-iOS platforms
markpokornycos
added a commit
that referenced
this issue
Mar 8, 2019
* renames schemes and targets to LaunchDarkly * renames test target and headers to LaunchDarkly * renames code and test folders to LaunchDarkly * renames xcode project to LaunchDarkly * renames workspace to LaunchDarkly * renames modules and sets Catamorphic Co as license holder in block header comment * renames podfile workspace and targets to LaunchDarkly * renames Jazzy components to LaunchDarkly * replaces outdated variable_name rule with identifier_name to clear swiftlint warnings * renames workspace and scheme to LaunchDarkly in circleCI * installs CocoaPods 1.6.0 * installs DarklyEventSource 4.0.1 * installs Quick 7.3.4 and Nimble 1.3.4 * installs SwiftLint 0.30.1 * Add instructions to integrate without a package manager (#57) * Replaces onServerUnavailable with ErrorObserver (#58) * Adds new logging around variationAndSource (#59) * Install keys to model objects (#60) * Adds Automated Tests for missing coverage (#61) * Decompress Blocks (#62) * Refine flag version handling (#63) * sets beta 3 version and updates public documents * Add Platform Names to non-iOS frameworks (#65) * renames all schemes, targets, and non-iOS products to include the platform * updates changelog and instructions for non-iOS platforms * updates items for public release * updates pods project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the file LDUserModel.m there are is the following compiler warning
LDUserModel.m:104:24: Incompatible pointer to integer conversion assigning to 'BOOL' (aka 'signed char') from 'id _Nullable'
Looking at the code:
The return value of objectForKey: is being assigned to a BOOL value:
@Property (nonatomic, assign) BOOL anonymous;
Can this code be fixed so that it explicitly sets the BOOL value rather than relying on the implicit assignment?
The text was updated successfully, but these errors were encountered: