Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significant performance issue in createFeatureEvent: caused by NSKeyedArchiver/NSKeyedUnarchiver #76

Closed
adc-amatosov opened this issue Dec 2, 2016 · 3 comments

Comments

@adc-amatosov
Copy link

On every feature flag check the following like is executed:
[[LDDataManager sharedManager] createFeatureEvent: featureKey keyValue:returnValue defaultKeyValue:fallback]; which is SYNCHRONOUSLY on the MAIN THREAD unarchiving a dictionary of objects, sets 1 key and archives all of them back.
This causes 70-90% CPU load on iPhone 6+ if called just 2 times a second.
This is a blocker for our release.

@justinucd
Copy link

Thanks for pointing this out - I'm going to create a support ticket so we can get this fixed ASAP - which email should I add to the ticket?

@adc-amatosov
Copy link
Author

amatosov.ctr at ten-x dot com

@arun251
Copy link

arun251 commented Apr 7, 2017

This was fixed and released in 2.1.0.

@arun251 arun251 closed this as completed Apr 7, 2017
torchhound added a commit that referenced this issue Jun 19, 2019
Fix for concurrency bug in FlagStore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants