feat: Introduce variation method with generic return types #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #160632: iOS SDK investigates a method to turn JSON LDValue into a dictionary or raw string for easy consumption.. |
keelerm84
force-pushed
the
mk/sc-160632/ld-value-raw
branch
from
5c1422b
to
abffc7f
Compare
tanderson-ld
approved these changes
Feb 15, 2024
Customers using a JSON flag often prefer the evaluation result return a custom object instead of an LDValue. This commit supports that by introducing a new `LDValueDecoder` (copied and lightly modified from the Swift Core Libs `JSONDecoder` implementation). This decoder allows decoding into arbitrary types directly from an LDValue, without paying the penalty for an intermediate JSON encoding step (i.e. LDValue -> JSON str -> Custom Type).
keelerm84
force-pushed
the
mk/sc-160632/ld-value-raw
branch
from
abffc7f
to
3d89db4
Compare
keelerm84
pushed a commit
that referenced
this pull request
Feb 22, 2024
🤖 I have created a release *beep* *boop* --- ## [9.4.0](9.3.0...9.4.0) (2024-02-21) ### Features * Add new identify method with time out support ([#344](#344)) ([34ba8ab](34ba8ab)) * Implement shedding identity queue ([#343](#343)) ([393a28c](393a28c)) * Introduce variation method with generic return types ([#342](#342)) ([7ff2ffb](7ff2ffb)) ### Bug Fixes * Add privacy manifest ([#334](#334)) ([154fde7](154fde7)) * Ensure anonymous context is valid ([#338](#338)) ([65406cc](65406cc)) * Replace simple logger with os_log statements ([#340](#340)) ([7ba4397](7ba4397)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: LaunchDarklyReleaseBot <LaunchDarklyReleaseBot@launchdarkly.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customers using a JSON flag often prefer the evaluation result return a custom object instead of an LDValue. This commit supports that by introducing a new
LDValueDecoder(copied and lightly modified from the Swift Core LibsJSONDecoderimplementation).This decoder allows decoding into arbitrary types directly from an LDValue, without paying the penalty for an intermediate JSON encoding step (i.e. LDValue -> JSON str -> Custom Type).