feat: Implement shedding identity queue #343
+359
−7
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| import Foundation | ||
|
|
||
| /** | ||
| Denotes the result of an identify request made through the `LDClient.identify(context: completion:)` method. | ||
| */ | ||
| public enum IdentifyResult { | ||
| /** | ||
| The identify request has completed successfully. | ||
| */ | ||
| case complete | ||
| /** | ||
| The identify request has received an unrecoverable failure. | ||
| */ | ||
| case error | ||
| /** | ||
| The identify request has been replaced with a subsequent request. See `LDClient.identify(context: completion:)` for more details. | ||
| */ | ||
| case shed | ||
|
|
||
| init(from: TaskResult) { | ||
| switch from { | ||
| case .complete: | ||
| self = .complete | ||
| case .error: | ||
| self = .error | ||
| case .shed: | ||
| self = .shed | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| import Foundation | ||
|
|
||
| enum TaskResult { | ||
| case complete | ||
| case error | ||
| case shed | ||
| } | ||
|
|
||
| typealias TaskHandlerCompletion = () -> Void | ||
| typealias TaskHandler = (_ completion: @escaping TaskHandlerCompletion) -> Void | ||
| typealias TaskCompletion = (_ result: TaskResult) -> Void | ||
|
|
||
| struct Task { | ||
| let work: TaskHandler | ||
| let sheddable: Bool | ||
| let completion: TaskCompletion | ||
| } | ||
|
|
||
| class SheddingQueue { | ||
| private let stateQueue: DispatchQueue = DispatchQueue(label: "StateQueue") | ||
| private let identifyQueue: DispatchQueue = DispatchQueue(label: "IdentifyQueue") | ||
|
|
||
| private var inFlight: Task? | ||
| private var queue: [Task] = [] | ||
|
|
||
| func enqueue(request: Task) { | ||
| stateQueue.async { [self] in | ||
| guard inFlight != nil else { | ||
| inFlight = request | ||
| identifyQueue.async { self.execute() } | ||
| return | ||
| } | ||
|
|
||
| if let lastTask = queue.last, lastTask.sheddable { | ||
| queue.removeLast() | ||
| lastTask.completion(.shed) | ||
| } | ||
|
|
||
| queue.append(request) | ||
| } | ||
| } | ||
|
|
||
| private func execute() { | ||
| var nextTask: Task? | ||
|
|
||
| stateQueue.sync { | ||
| nextTask = inFlight | ||
| } | ||
|
|
||
| if nextTask == nil { | ||
| return | ||
| } | ||
|
|
||
| guard let request = nextTask else { return } | ||
|
|
||
| request.work() { [self] in | ||
| request.completion(.complete) | ||
|
|
||
| stateQueue.sync { | ||
| inFlight = queue.first | ||
| if inFlight != nil { | ||
| queue.remove(at: 0) | ||
| identifyQueue.async { self.execute() } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecating this method so that customers will start moving over to the callback that informs them of success or failure.