Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate builds using CI #81

Merged
merged 4 commits into from
Jan 24, 2017
Merged

Automate builds using CI #81

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f7051fc
Automate builds
danialzahid94 Jan 23, 2017
cb89e91
Remove deployment script
danialzahid94 Jan 23, 2017
7adb98b
Separate master and branch testing
danialzahid94 Jan 23, 2017
f337d18
Fix bash bug
danialzahid94 Jan 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion circle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@ machine:

test:
post:
- pod lib lint
- pod lib lint
- if [ "$CIRCLE_BRANCH" = 'master' ]; then pod spec lint; fi
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only lint on Master?

Copy link
Author

@danialzahid94 danialzahid94 Jan 23, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pod lib lint only validates the pod locally, and does not check for the rights tags etc. Although, having this for any branch/PR is beneficial to verify and identify any issues before hand and fix within the same branch/PR.
pod spec lint does a full remote validation, and requires for the respective tag for tat version to be available on the master branch. Because of this, spec lint should be run when everything is finalized.
For this reason, pod spec lint is configured to run only when committed to master.