Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove bundled dependency from package.json. #711

Merged
merged 2 commits into from
Dec 12, 2024
Merged

fix: Remove bundled dependency from package.json. #711

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78db12c
fix: Remove bundled dependency from package.json.
kinyoklion Dec 11, 2024
3b31ba1
Add as normal dependency
kinyoklion Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions packages/sdk/cloudflare/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@
},
"dependencies": {
"@cloudflare/workers-types": "^4.20230321.0",
"@launchdarkly/js-server-sdk-common-edge": "2.5.2",
"crypto-js": "^4.1.1"
},
"devDependencies": {
"@launchdarkly/js-server-sdk-common-edge": "2.5.2",
"@rollup/plugin-commonjs": "^25.0.4",
"@rollup/plugin-json": "^6.0.0",
"@rollup/plugin-node-resolve": "^15.2.1",
Expand Down Expand Up @@ -76,8 +76,5 @@
"ts-jest": "^29.1.0",
"typedoc": "0.25.0",
"typescript": "5.1.6"
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't do what it was intended to do, but did cause a warning on install.
Basically this dependency is bundled with rollup, but this package.json indicates that the package would contain a .tgz file with this dependency in it.

"bundledDependencies": [
"@launchdarkly/js-server-sdk-common-edge"
]
}
}
Loading