Add failing test for reason change #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps it would be possible to add a new change event |
|
I believe I understand the desired use case, and that might be a good idea, but I'm going to close this PR because it isn't actually a pull request for code that can merged into the SDK on its own. Anything that would, if merged, cause the build to fail should not be a PR. |
3 tasks
LaunchDarklyCI
pushed a commit
that referenced
this pull request
Feb 12, 2020
(2) clean up stream testing logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just wanted to highlight a behaviour in the SDK that isn't ideal for our use case.
Essentially we rely on the
change:<flag-key>event to know when we should runvariationDetailto get the latest flag details. However, this event is not triggered when the reason property changes. As such, we can't know if the reason we currently have is the most recent one. I guess we can workaround this by pollingvariationDetail, but I find that to defeat the purpose of the change event.