Enabled status at top of Treeview #51

InTheCloudDan · 2020-10-16T00:12:43Z

Moving the status of the flag to the top so you do not need to expand to see it.

Also started cleaning up the complicated Treeview generation.

This PR also includes a slight change to #49 in that if a variation is changed then it will still retrieve the flag as soon as the plugin receives notice. This is because Variations are the only part of the global data model that can affect environment specific targeting so for future functionality those should also be in sync.

treeview gets all info from flagstore add refresh rate config options

disable events

remove console logs

remove commented lines

change comparison

Co-authored-by: Arnold Trakhtenberg <arnold@launchdarkly.com>

move enabled icon to top level

atrakh · 2020-10-22T22:42:02Z

src/flagStore.ts

-			const flags = await this.api.getFeatureFlags(this.config.project, this.config.env);
+			const getFlags = await this.api.getFeatureFlags(this.config.project, this.config.env);
+			const flags = getFlags.map(flag => {
+				flag.variationLength = flag.variations.length;


🤔 Any reason why we can't always reference flag.variations.length instead of copying the length to a new field?

yeah I think that should be doable I'll make the change and test it

atrakh · 2020-10-22T22:45:16Z

src/flagStore.ts

@@ -146,10 +165,11 @@ export class FlagStore {
 	}

 	private ldConfig(): Record<string, number | string | boolean | LaunchDarkly.LDFeatureStore> {
+		const streamUri = this.config.baseUri.replace('app', 'stream');


Are you recommending we remove the streamUri config option? I'm not sure this replace always be accurate in a development environment.

atrakh · 2020-10-22T22:46:54Z

src/flagStore.ts

+						}
+					});
+				});
+			});


What is the purpose of this new block? Were updates not being made when the number of variations changed before?

as of right now(before PR this one is based one) every time there's a flag update we get the latest flag via API. Per our conversation I changed it so the control plane data only updates on the refreshRate.

What this changes is so that it only updates on refreshRate except when there's a variation change. Because variations span the global flag config and environment targeting where almost nothing else does.

atrakh · 2020-10-22T22:50:21Z

src/providers/flagsView.ts

@@ -470,17 +466,12 @@ export class FlagNode extends vscode.TreeItem {
 		this.conditionalIcon(ctx, this.contextValue, this.label);
 	}

-	private conditionalIcon(ctx: vscode.ExtensionContext, contextValue: string, label: string) {
+	private conditionalIcon(ctx: vscode.ExtensionContext, contextValue: string, label: string, enabled?: boolean) {


This new param appears to be unused in conditionalIcon

without it the Interface does not work, it says the signatures do not match. I'm not sure how to approach it better.

atrakh · 2020-10-22T22:50:52Z

src/providers/flagsView.ts

+			dark: ctx.asAbsolutePath(path.join('resources', 'dark', fileName + '.svg')),
+		});
+	}
+}


Are the methods in this new class identical to the ones above? Do we need both?

the methods are the same currently as this is step 1. The logic within the methods is getting cleaned up also. I'm also trimming down the number of properties per class and in the future will move additional nodes like variations to their own class so it's less of a tangle of procedural code.

* Store Refactor - Redo (#49) * only update global flag metadata based on refresh rate treeview gets all info from flagstore add refresh rate config options * lint * remove console * remove unused imports disable events * make event readonly * make metadata private remove console logs * fixes to work for initial install * remove console * remove unused property and function * remove unused function * remove console log * named import for lodash remove commented lines * remove unneeded window message change comparison * fix promises * remove unused function * Update src/extension.ts Co-authored-by: Arnold Trakhtenberg <arnold@launchdarkly.com> * Update src/extension.ts Co-authored-by: Arnold Trakhtenberg <arnold@launchdarkly.com> * fixes * remove console log Co-authored-by: Dan O'Brien <dobrien@launchdarkly.com> Co-authored-by: Arnold Trakhtenberg <arnold@launchdarkly.com> * User Agent (#52) * update User-Agent * fix error message * Enabled status at top of Treeview (#51) * move enabled icon to top level * handle changes in variations * add basic interface between classes * Using Code References to Power Aliases (#50) * Check coderefs version * remove console logs * set timeout on child process * lint * remove unused taskDefinition * check coderefs path is set * lint * add search ability * add icons for searching aliases * add list of keys as property * remove unused statusbar command * update to list of map keys * API Interactions (#55) * basic API changes working * clean up implementation * update icons and names * error handling * Add Basic CodeLens functionality (#59) * add key to flag lens * stringify values * remove unused api property * Code Lens Hover (#53) * update hover * updated hover right click flag toggle poc * context menu changes * check for coderefs yaml * remove duplicate identifier * fix getMap in flag lens * fix offlining when not in focus * Updated tree node UI (#57) * only update global flag metadata based on refresh rate treeview gets all info from flagstore add refresh rate config options * lint * remove console * remove unused imports disable events * make event readonly * make metadata private remove console logs * fixes to work for initial install * remove console * remove unused property and function * remove unused function * remove console log * named import for lodash remove commented lines * remove unneeded window message change comparison * fix promises * remove unused function * Update src/extension.ts Co-authored-by: Arnold Trakhtenberg <arnold@launchdarkly.com> * Update src/extension.ts Co-authored-by: Arnold Trakhtenberg <arnold@launchdarkly.com> * fixes * remove console log * start cleaning up flagview move enabled icon to top level * handle changes in variations * add basic interface between classes * lint * fix off variation * add context check back * lint * add basic test * fix missing paranthesis * test fixes * update enabled icons * remove variation length property * update model * update changelog * initial code refs * Alias Treeview Alias Tree search * lint * add config * remove console log * Check coderefs version remove console logs set timeout on child process * lint * remove unused taskDefinition check coderefs path is set * lint * add search ability add icons for searching aliases * add list of keys as property remove unused statusbar command * update to list of map keys * rename getter * basic API changes working * clean up implementation * update icons and names * error handling * not working * lens resolving add configuration option * show variations served * handle no default * codelens on aliases basic support * eslint ignore remove console.log * add key to flag lens stringify values * remove console log * only Stringify object * fix rebase * remove unused api property * update for rebase * check if keys is defined * codelens on aliases basic support * update hover * updated hover right click flag toggle poc * context menu changes * check for coderefs yaml rebase cleanup * fix getKeys when aliases do not exist * lint * Updated tree node UI * Fix for test * Fix for test * Updated toggle icons * New popover UI Co-authored-by: Dan O'Brien <dobrien@launchdarkly.com> Co-authored-by: Dan O'Brien <dobrien.nj@gmail.com> Co-authored-by: Arnold Trakhtenberg <arnold@launchdarkly.com> * Fix tests * Prettier updates * Add GH action to publish to registry * Change name of publisher * Updated version and icon * Change name to LaunchDarkly Beta * Fix version * Change ver to 3.0.0 * Coderefs download (#60) * initial download of code refs * update config check to run coderefs * fix aliases section showing in treeview if no aliases * platform agnostic path for coderefs * Fix test * updated dependencies (#61) * prettier fixes * eslint and type updates * more prettier fixes * Automate version and name change for beta build * Change version format * One more to conform to version specs * Don't create a beta release unless it's on the beta branch * Only publish on v3 branch * No need to check branch separately * Added snapshot testing, resized hover icons * Fix prettier issue * Publish beta under launchdarkly-beta id * Publish to OpenVSX * s/v3/beta * Fix prettier * Color theme is in the wrong case * ignore coderefs dir handle high contrast theme * fix error interpolation remove codelens array private var null check on flag variation * Activation add Ignore for this workspace [ch98567] (#62) * Activation Add configure buttons to sidebar [ch98569] (#63) * Activation add Ignore for this workspace [ch98567] * Activation Add configure buttons to sidebar [ch98569] * Remove .vscode/settings.json * check aliases for hover * move flag search to parent node * prettier fixes * Icon color changes, turn off codelens on prod, use yarn for build * Updated docs * Change formatting * move hover provider to own file implement fix for auto-complete * update test * Config Hide advanced config settings like [ch98573] (#64) There are also a few other things included in this commit: change version # pattern for beta, updated config descriptions, and turn off all other extensions when in debug mode. * Reverting back to previous versioning scheme Even though vsce says that it supports semver, it turns out that the Marketplace doesn't support prereleases (microsoft/vscode-vsce#415 (comment)) * Change default name to LaunchDarkly * do not show error when SDK handles it Co-authored-by: Dan O'Brien <dobrien.nj@gmail.com> Co-authored-by: Dan O'Brien <dobrien@launchdarkly.com> Co-authored-by: Arnold Trakhtenberg <arnold@launchdarkly.com>

InTheCloudDan and others added 20 commits September 21, 2020 12:56

only update global flag metadata based on refresh rate

5eb5614

treeview gets all info from flagstore add refresh rate config options

lint

4633096

remove console

bec33f1

remove unused imports

0b70c3f

disable events

make event readonly

06276de

make metadata private

62c4f6e

remove console logs

fixes to work for initial install

091fb98

remove console

e06bc2b

remove unused property and function

86d64eb

remove unused function

3301af7

remove console log

fd18f47

named import for lodash

57a35ff

remove commented lines

remove unneeded window message

7065135

change comparison

fix promises

fe9fbd2

remove unused function

2ce09eb

Update src/extension.ts

0a2cb30

Co-authored-by: Arnold Trakhtenberg <arnold@launchdarkly.com>

Update src/extension.ts

f6a593d

Co-authored-by: Arnold Trakhtenberg <arnold@launchdarkly.com>

fixes

41b3600

remove console log

46e502b

start cleaning up flagview

9ae7651

move enabled icon to top level

InTheCloudDan requested a review from atrakh October 16, 2020 00:12

InTheCloudDan added 9 commits October 17, 2020 17:57

handle changes in variations

11de494

add basic interface between classes

5f62918

lint

9d94bd8

fix off variation

9c423aa

add context check back

79159d8

lint

444a0d0

add basic test

5d4fb54

fix missing paranthesis

92d1624

test fixes

2109fea

atrakh changed the base branch from master to storeRedo October 22, 2020 22:40

atrakh reviewed Oct 22, 2020

View reviewed changes

InTheCloudDan added 4 commits October 26, 2020 15:57

update enabled icons

059bbad

remove variation length property

2dd1d02

update model

45aa4fb

update changelog

c57548a

InTheCloudDan changed the base branch from storeRedo to v3 December 11, 2020 22:41

Merge branch 'v3' into enabledStatus

7dba2f1

InTheCloudDan merged commit 9174f88 into v3 Dec 11, 2020

InTheCloudDan deleted the enabledStatus branch February 17, 2021 13:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enabled status at top of Treeview #51

Enabled status at top of Treeview #51

InTheCloudDan commented Oct 16, 2020 •

edited

Loading

atrakh Oct 22, 2020

InTheCloudDan Oct 22, 2020

atrakh Oct 22, 2020 •

edited

Loading

atrakh Oct 22, 2020

InTheCloudDan Oct 22, 2020

atrakh Oct 22, 2020

InTheCloudDan Oct 22, 2020

atrakh Oct 22, 2020

InTheCloudDan Oct 22, 2020

Enabled status at top of Treeview #51

Enabled status at top of Treeview #51

Conversation

InTheCloudDan commented Oct 16, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

atrakh Oct 22, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

InTheCloudDan commented Oct 16, 2020 •

edited

Loading

atrakh Oct 22, 2020 •

edited

Loading