Don't panic with nil tracking response body (#192)

launchdarkly · Apr 19, 2024 · 7710b33 · 7710b33
1 parent 476f8c6
commit 7710b33
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/internal/analytics/client.go b/internal/analytics/client.go
@@ -62,11 +62,13 @@ func (c *Client) SendEvent(
 		if err != nil { //nolint:staticcheck
 			// TODO: log error
 		}
-		if resp != nil {
-			resp.Body.Close()
+		if resp == nil {
+			c.wg.Done()
+			return
 		}
+		resp.Body.Close()
 
-		_, err := io.ReadAll(resp.Body)
+		_, err = io.ReadAll(resp.Body)
 		if err != nil { //nolint:staticcheck
 			// TODO: log error
 		}

diff --git a/internal/quickstart/messages.go b/internal/quickstart/messages.go
@@ -231,9 +231,6 @@ func fetchFlagStatus(
 	}
 }
 
-// noInstructionsMsg is sent when we can't find the SDK instructions repository for the given SDK.
-type noInstructionsMsg struct{}
-
 type selectedSDKMsg struct {
 	index int
 }