feat: Remove the sync endpoint in favor of patch project endpoint (#431)

* Remove the sync endpoint in favor of patch project endpoint

* update sync command

cmd/dev_server/dev_server.go

@@ -3,11 +3,12 @@ package dev_server
 import (
 	"fmt"
 
-	cmdAnalytics "github.com/launchdarkly/ldcli/cmd/analytics"
-	"github.com/launchdarkly/ldcli/internal/analytics"
 	"github.com/spf13/cobra"
 	"github.com/spf13/viper"
 
+	cmdAnalytics "github.com/launchdarkly/ldcli/cmd/analytics"
+	"github.com/launchdarkly/ldcli/internal/analytics"
+
 	"github.com/launchdarkly/ldcli/cmd/cliflags"
 	resourcecmd "github.com/launchdarkly/ldcli/cmd/resources"
 	"github.com/launchdarkly/ldcli/internal/dev_server"

cmd/dev_server/projects.go

@@ -108,17 +108,21 @@ func NewSyncProjectCmd(client resources.Client) *cobra.Command {
 
 func syncProject(client resources.Client) func(*cobra.Command, []string) error {
 	return func(cmd *cobra.Command, args []string) error {
-
-		path := getDevServerUrl() + "/dev/projects/" + viper.GetString(cliflags.ProjectFlag) + "/sync"
-		res, err := client.MakeUnauthenticatedRequest(
+		project := viper.GetString(cliflags.ProjectFlag)
+		path := fmt.Sprintf("%s/dev/projects/%s", getDevServerUrl(), project)
+		_, err := client.MakeUnauthenticatedRequest(
 			"PATCH",
 			path,
-			nil,
+			// An empty body sent to the patch project endpoint = sync project
+			[]byte("{}"),
 		)
 		if err != nil {
 			return output.NewCmdOutputError(err, viper.GetString(cliflags.OutputFlag))
 		}
-		fmt.Fprint(cmd.OutOrStdout(), string(res))
+		_, err = fmt.Fprintf(cmd.OutOrStdout(), "'%s' project synced successfully\n", project)
+		if err != nil {
+			return err
+		}
 
 		return nil
 	}

internal/dev_server/api/api.yaml

@@ -24,18 +24,6 @@ paths:
                 items:
                   type: string
                 uniqueItems: true
-  /dev/projects/{projectKey}/sync:
-    patch:
-      summary: updates the flag state for the given project and source environment
-      operationId: patchSyncProject
-      parameters:
-        - $ref: "#/components/parameters/projectKey"
-        - $ref: "#/components/parameters/projectExpand"
-      responses:
-        200:
-          $ref: "#/components/responses/Project"
-        404:
-          description: No project found
   /dev/projects/{projectKey}:
     get:
       summary: get the specified project and its configuration for syncing from the LaunchDarkly Service
@@ -49,7 +37,7 @@ paths:
         404:
           description: No project found
     patch:
-      summary: updates the project context or sourceEnvironmentKey
+      summary: updates the project context or sourceEnvironmentKey then syncs.  Input an empty body to only force a sync.
       operationId: patchProject
       parameters:
         - $ref: "#/components/parameters/projectKey"

internal/dev_server/ui/src/Sync.tsx

@@ -13,11 +13,10 @@ import { FlagVariation } from './api.ts';
 
 const syncProject = async (selectedProject: string) => {
   const res = await fetch(
-    apiRoute(
-      `/dev/projects/${selectedProject}/sync?expand=availableVariations`,
-    ),
+    apiRoute(`/dev/projects/${selectedProject}?expand=availableVariations`),
     {
       method: 'PATCH',
+      body: JSON.stringify({}),
     },
   );