fix: create flag prompt should be on the same line as text #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #239302: create flag prompt should be on the same line as text. |
k3llymariee
commented
Apr 4, 2024
| @@ -24,6 +24,7 @@ func NewCreateFlagModel(client flags.Client, accessToken, baseUri string) tea.Mo | |||
| ti.Focus() | |||
| ti.CharLimit = 156 | |||
| ti.Width = 20 | |||
| ti.Prompt = "" | |||
There was a problem hiding this comment.
this gets rid of the ">"
| @@ -68,8 +69,7 @@ func (m createFlagModel) View() string { | |||
| MarginLeft(2) | |||
|
|
|||
| return fmt.Sprintf( | |||
| "Name your first feature flag (enter for default value %q):\n\n%s", | |||
| defaultFlagName, | |||
There was a problem hiding this comment.
i removed this because the prompt felt a little long to have on one line with the input. plus with the new confirmation step they'll see the value that was used.
dbolson
approved these changes
Apr 5, 2024
This was referenced Apr 5, 2024
This was referenced Apr 8, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before:
after:
