Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create flag prompt should be on the same line as text #135

Merged
merged 2 commits into from
Apr 5, 2024
Merged

fix: create flag prompt should be on the same line as text #135

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9834a1
create flag prompt should be on the same line as text
k3llymariee Apr 4, 2024
adc8af6
shorten prompt
k3llymariee Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/quickstart/create_flag.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ func NewCreateFlagModel(client flags.Client, accessToken, baseUri string) tea.Mo
ti.Focus()
ti.CharLimit = 156
ti.Width = 20
ti.Prompt = ""
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this gets rid of the ">"


return createFlagModel{
accessToken: accessToken,
Expand Down Expand Up @@ -68,8 +69,7 @@ func (m createFlagModel) View() string {
MarginLeft(2)

return fmt.Sprintf(
"Name your first feature flag (enter for default value %q):\n\n%s",
defaultFlagName,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i removed this because the prompt felt a little long to have on one line with the input. plus with the new confirmation step they'll see the value that was used.

"Name your first feature flag (enter for default value):%s",
style.Render(m.textInput.View()),
) + "\n"
}
Loading