fix: remove side borders from show SDK viewport #162
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when copy/pasting the sdk instructions with a border for the viewport, we end up with something like this on the clipboard:
My proposed solution is to remove the side borders - with the additional help keys at the bottom it should hopefully be clear that the text is scrollable, but open to opinions.
An alternative would be to use a
HiddenBackground
with aBorderBackground
color, which would look something like this: