Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove side borders from show SDK viewport #162

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

k3llymariee
Copy link
Contributor

@k3llymariee k3llymariee commented Apr 10, 2024

I noticed that when copy/pasting the sdk instructions with a border for the viewport, we end up with something like this on the clipboard:

│  3. Create a file called  test.py  and add the following code:                 │
│                                                                                │
│    # Import the LaunchDarkly client.                                           │
│    import ldclient                                                             │
│    from ldclient import Context                                                │
│    from ldclient.config import Config                                          │
│                                                                                │
│    # Create a helper function for rendering messages.                          │
│    def show_message(s):                                                        │
│        print("*** {}".format(s))                                               │
│        print()                                                                 │

My proposed solution is to remove the side borders - with the additional help keys at the bottom it should hopefully be clear that the text is scrollable, but open to opinions.

borders

An alternative would be to use a HiddenBackground with a BorderBackground color, which would look something like this:
image

Copy link
Contributor

@dbolson dbolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

Base automatically changed from kelly/sc-239828/remove-mouse-wheel-support-from-show-sdk to main April 10, 2024 18:04
@k3llymariee k3llymariee merged commit d111c61 into main Apr 10, 2024
3 checks passed
@k3llymariee k3llymariee deleted the kelly/fix-show-sdk-border branch April 10, 2024 18:04
@sunnyguduru sunnyguduru mentioned this pull request Apr 15, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants