chore: show a nicer error message when toggle a flag fails #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbolson
commented
Apr 15, 2024
| @@ -60,6 +60,35 @@ func confirmedFlag(flag flag) tea.Cmd { | |||
| } | |||
| } | |||
|
|
|||
| type msgRequestError struct { | |||
There was a problem hiding this comment.
Creates a new type to encapsulate converting from the API response to something we handle in messages and models.
| existingFlag = e.Code == "conflict" | ||
| if !existingFlag { | ||
| return errMsg{err: errors.NewError(fmt.Sprintf("Error creating flag: %s. Press \"ctrl + c\" to quit.", e.Message))} | ||
| msgRequestErr, err := newMsgRequestError(err.Error()) |
There was a problem hiding this comment.
We have to handle this here since we don't consider a conflict an error, unlike the toggle flag command where a conflict is still an error.
| return m, toggleFlag(m.client, m.accessToken, m.baseUri, m.flagKey, m.enabled) | ||
| } | ||
| case errMsg: | ||
| msgRequestErr, err := newMsgRequestError(msg.err.Error()) |
There was a problem hiding this comment.
We handle the error here since we're mapping the API error response to a model-specific response.
sunnyguduru
approved these changes
Apr 15, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
Provide a clear and concise description of what you expect to happen.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the pull request here.