feat: output flag all commands #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbolson
commented
Apr 23, 2024
cmd/flags/create.go
Outdated
| @@ -74,7 +75,15 @@ func runCreate(client flags.Client) func(*cobra.Command, []string) error { | |||
| return err | |||
| } | |||
|
|
|||
| fmt.Fprintf(cmd.OutOrStdout(), string(response)+"\n") | |||
| output, err := output.CmdOutput( | |||
There was a problem hiding this comment.
@k3llymariee At some point for the dynamic endpoint function, we'll need a field that defines which function to call for each action.
dbolson
requested review from
sunnyguduru and
k3llymariee
and removed request for
sunnyguduru
sunnyguduru
approved these changes
Apr 24, 2024
k3llymariee
approved these changes
Apr 24, 2024
* Show plaintext response for config --list * Use map for output type * Refactor types * Organization * Remove extra type * feat: output flag errors (#204) * Add plain text error handling * Output flag errors as plain text or JSON * Remove unused code * Update all commands to return plaintext or JSON * Refactor outputter * Backfill tests * Reorganize * Refactor * Remove comments * Renamed functions
dbolson
changed the title
This was referenced Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets up support for the output flag for all endpoints except config (for now).
Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
Provide a clear and concise description of what you expect to happen.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the pull request here.