fix: toggle flag aliases #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbolson
commented
May 10, 2024
| @@ -395,7 +395,8 @@ Global Flags: | |||
| Additional help topics:{{range .Commands}}{{if .IsAdditionalHelpTopicCommand}} | |||
| {{rpad .CommandPath .CommandPathPadding}} {{.Short}}{{end}}{{end}}{{end}}{{if .HasAvailableSubCommands}} | |||
|
|
|||
| Use "{{.CommandPath}} [command] --help" for more information about a command.{{end}}` | |||
| Use "{{.CommandPath}} [command] --help" for more information about a command.{{end}} | |||
| ` | |||
There was a problem hiding this comment.
Added this newline so the prompt wouldn't end up on the last line as the help output, consistent with the other inline templates.
| @@ -182,6 +183,14 @@ func NewRootCommand( | |||
| cmd.AddCommand(resourcecmd.NewResourcesCmd()) | |||
| resourcecmd.AddAllResourceCmds(cmd, clients.ResourcesClient, analyticsTrackerFn) | |||
|
|
|||
| // add non-generated commands | |||
There was a problem hiding this comment.
We can add other aliased or other commands here.
|
|
||
| import "net/url" | ||
|
|
||
| type MockClient struct { |
There was a problem hiding this comment.
I ended up not going with the testify mock code. If you'd prefer that way, I can change this.
k3llymariee
approved these changes
May 10, 2024
| "ldcli/internal/resources" | ||
| ) | ||
|
|
||
| func NewToggleOnCmd(client resources.Client) *cobra.Command { |
There was a problem hiding this comment.
I think we also need to set the usage template for these, in order to parse out the required/optional flags
There was a problem hiding this comment.
Updated. Help now looks like this
Turn a feature flag on
Usage:
ldcli flags toggle-on [flags]
Required flags:
--environment string The environment key
--flag string The feature flag key
--project string The project key
Optional flags:
Global Flags:
-h, --help Help for this command
--access-token string LaunchDarkly access token with write-level access
--analytics-opt-out Opt out of analytics tracking
--base-uri string LaunchDarkly base URI (default "https://app.launchdarkly.com")
-o, --output string Command response output format in either JSON or plain text (default "plaintext")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
flags toggle-on/toggle-offactions back.Running
ldcli flags --helpshows the new actions:Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
Provide a clear and concise description of what you expect to happen.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the pull request here.