chore: update Release Please config for GA #295
Conversation
.release-please-manifest.json
Outdated
| @@ -1,3 +1,3 @@ | |||
| { | |||
| ".": "0.13.0" | |||
| ".": "1.0.0" | |||
There was a problem hiding this comment.
is this right? we did already have a 1.0.0 at some point before so I'm not actually sure this will work
There was a problem hiding this comment.
You can't update the manifest directly - it'll confuse release-please, since this is what records the existing version. Instead, you can add a ! to a PR/commit title.
Example: feat!: some feature that triggers the GA releases
There was a problem hiding this comment.
There was a problem hiding this comment.
ok cool wasn't sure!
There was a problem hiding this comment.
(If you don't have any last minute changes that you can add the ! to, you can also do it on a previous PR. (this is something we do all the time in SDKs if we accidentally forgot something.)
There was a problem hiding this comment.
cool i'm going to merge this one in soon, so maybe just this? #293
Updating the release please config to (hopefully) allow for a 1.0.0 release. Please let me know if I've missed anything! I probably did!