Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Build windows binary #314

Merged
merged 2 commits into from
Jun 4, 2024
Merged

fix: Build windows binary #314

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d595ca1
Build windows binary
dbolson May 31, 2024
cb27d81
Add goarch values
dbolson Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .goreleaser.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@ builds:
- id: ldcli
binary: ldcli
goos:
- linux
- darwin
- linux
- windows
goarch:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we need to specify the goarch values. When I generated a default goreleaser config file it only specifies the goos values.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't specify goarch, the docs say the default is '386', 'amd64', 'arm64'. So not sure we need to build for 32 bit processors, but it probably wouldn't hurt.

Copy link
Contributor Author

@dbolson dbolson Jun 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cwaldren-ld Screenshot 2024-06-03 at 4 12 19 PM
Updated with defined GOARCH values.

- 386
- amd64
- arm64
env:
Expand Down
Loading