Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Send slack notification on failure #318

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

dbolson
Copy link
Contributor

@dbolson dbolson commented Jun 5, 2024

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

Provide links to any issues in this repository or elsewhere relating to this pull request.

Describe the solution you've provided

Provide a clear and concise description of what you expect to happen.

Describe alternatives you've considered

Provide a clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context about the pull request here.

@@ -12,3 +12,19 @@ jobs:
- uses: actions/checkout@v4
- name: Check OpenAPI updates
run: make openapi-spec-check-updates
on-failure:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on this post.

@dbolson dbolson requested a review from k3llymariee June 5, 2024 21:13
env:
SLACK_CHANNEL: proj-cli
SLACK_COLOR: ${{ job.status }}
SLACK_ICON_EMOJI: ':launchdarkly:'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SLACK_ICON_EMOJI: ':launchdarkly:'
SLACK_ICON_EMOJI: ':robot-grimace:'

jk kinda

@dbolson dbolson merged commit 06073ae into main Jun 5, 2024
2 checks passed
@dbolson dbolson deleted the sc-241158/notify-on-failure branch June 5, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants