feat: Can fetch a token based on the device code #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbolson
commented
Jun 18, 2024
| @@ -22,7 +22,7 @@ func (c *mockClient) MakeRequest( | |||
| ) ([]byte, error) { | |||
| args := c.Called(method, path, data) | |||
|
|
|||
| return data, args.Error(1) | |||
| return args.Get(0).([]byte), args.Error(1) | |||
There was a problem hiding this comment.
This should return the Return part of the mock, not the method's input.
| @@ -38,11 +38,17 @@ func TestFetchDeviceAuthorization(t *testing.T) { | |||
| }`), | |||
| ).Return([]byte(`{ | |||
| "deviceCode": "test-device-code", | |||
| "expiresIn": 0000000001, | |||
| "expiresIn": 1, | |||
There was a problem hiding this comment.
Since this is an int.
moribellamy
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During login, after receiving a verification URL, we can make a request to it and, after the user has allowed access, it returns an access token.
Additional PRs will poll the endpoint and handle the various errors it can return.
Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
Provide a clear and concise description of what you expect to happen.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the pull request here.