feat: use SDK metadata #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
force-pushed
the
cw/sc-242846/sdk-metadata
branch
2 times, most recently
from
1572817
to
066e639
Compare
cwaldren-ld
force-pushed
the
cw/sc-242846/sdk-metadata
branch
from
066e639
to
c18a0a6
Compare
|
The majority of the changes are |
dbolson
approved these changes
Aug 12, 2024
| selectedIndex int | ||
| selectedSDK sdkDetail | ||
| } | ||
|
|
||
| func NewChooseSDKModel(selectedIndex int) tea.Model { | ||
| initSDKs() | ||
| l := list.New(sdksToItems(), sdkDelegate{}, 30, 9) | ||
| sdkDetails := initSDKs() |
There was a problem hiding this comment.
I updated the PR to not use the global var but pass this list around instead. It felt weird to modify it when we could encapsulate it in the model.
| } | ||
| index := slices.Index(sdkOrder, id) | ||
| if index == -1 { | ||
| // if we missed an SDK don't add it with an invalid index |
There was a problem hiding this comment.
Without this, there's a panic since it would later try to reference a -1 index. It shouldn't happen unless we change the SDK ID and forget to update the order list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI currently hard-codes certain information about LaunchDarkly SDKs, including example links, display names, and SDK types (server, client, and so on.)
This information must be manually kept up-to-date by the CLI maintainers or SDK engineers.
With the introduction of the
sdk-metaGo module, we're able to source this metadata externally.As background, whenever a LaunchDarkly SDK's metadata is updated (example), the sdk-meta project crawls the changes and generates a new Go module version.
In this PR, I've removed data that is now provided by the sdk-meta module. SDK example links are not yet part of the sdk-meta project, so I transformed those into a simple lookup table.
Finally, I renamed the SDK quickstart instruction files. To retrieve metadata for a particular SDK, you need the SDK's ID. It makes sense to define this as part of the filename.
The effect is that if you add a new quickstart instruction with a particular SDK ID, metadata will be automatically found for it.