fix: Propagate dev server errors in CLI compatible format #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
reviewed
Aug 26, 2024
| ) | ||
|
|
||
| type errorHandler struct { | ||
| code string |
There was a problem hiding this comment.
nit: Code seems like a strange name for this. It looks like statusText.
There was a problem hiding this comment.
Tragically, this is the convention in our API.
There was a problem hiding this comment.
Cool. I figured there was a reason for it.
There was a problem hiding this comment.
I added a comment to indicate that this is not ideal.
kinyoklion
approved these changes
Aug 26, 2024
dbolson
approved these changes
Aug 26, 2024
mike-zorn
deleted the
mikezorn/sc-253913/project-create-errors-aren-t-propagated-to
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that errors from the dev server are propagated back to the CLI in a way that the CLI can reasonably render. This way, we can return something that gives the user an idea of what went wrong vs. a generic "unexpected error" message.
example