feat: Display source environment in LaunchDevly UI #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdelst
changed the title
cdelst
changed the title
cdelst
commented
Sep 4, 2024
| @@ -23,61 +29,70 @@ function Flags({ selectedProject, flags, setFlags }: FlagProps) { | |||
| Record<string, FlagVariation[]> | |||
| >({}); | |||
|
|
|||
| const overridesPresent = overrides && Object.keys(overrides).length > 0; | |||
| const overridesPresent = useMemo( | |||
There was a problem hiding this comment.
best practice to not recalculate these every time
cdelst
commented
Sep 4, 2024
| ...{ | ||
| [flagKey]: { | ||
| value: overrideValue, | ||
| const updateOverride = useCallback( |
There was a problem hiding this comment.
useCallback lets us cache this func definition between renders
There was a problem hiding this comment.
Do we want that though? We closure in the override state...
There was a problem hiding this comment.
ohhh, I see you also pass in the deps.
mike-zorn
approved these changes
Sep 4, 2024
cdelst
merged commit 1e92281
into
mikezorn/sc-254693/validate-overrides-against-what-s-in-the
7 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements