feat: pass in optional role flag when using members invite #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #238446: pass in option |
dbolson
approved these changes
Mar 28, 2024
cmd/members/invite.go
Outdated
| @@ -33,6 +33,19 @@ func NewInviteCmd(client members.Client) (*cobra.Command, error) { | |||
| return nil, err | |||
| } | |||
|
|
|||
| var role string | |||
| cmd.Flags().StringVarP( | |||
There was a problem hiding this comment.
Could this be StringP instead if we don't need the local role var?
| @@ -85,3 +85,59 @@ func TestInvite(t *testing.T) { | |||
| assert.EqualError(t, err, "base-uri is invalid"+errorHelp) | |||
| }) | |||
| } | |||
|
|
|||
| func TestInviteWithOptionalRole(t *testing.T) { | |||
There was a problem hiding this comment.
Not a blocker, but you could probably make these subtests of TestInvite.
k3llymariee
deleted the
kelly/sc-238446/pass-in-option-role-flag-for-invite-members
branch
This was referenced Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional flag for the
members invitecommand to pass in a built-in role that will apply to all members invited. Default value is reader.