This repository has been archived by the owner on May 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add unit tests for default value bug
refactor LDClient tests and add some new ones
# Conflicts: # test/LDClient-test.js
add option to reduce front-end metadata for untracked flags
fix broken event source construction
add tests for CachingStoreWrapper + misc bug fixes
basic tests for UpdateQueue
better config validation
use CircleCI for Windows build
add more end-to-end tests, improve HTTP test helpers, general cleanup
change asyncify to promisifySingle
…n-fixes minor fixes to config validation messages + add comment
revise tests to use new helper package
bwoskow-ld
approved these changes
Dec 11, 2019
LaunchDarklyCI
pushed a commit
that referenced
this pull request
Jan 6, 2020
don't let user fall outside of last bucket in rollout
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[5.10.0] - 2019-12-11
Added:
RedisFeatureStore
now accepts an optionalclient
parameter, if you have an existingRedisClient
instance that you want to reuse.Changed:
baseUri:3
oroffline:"yes"
. For boolean properties, the SDK will still interpret the value in terms of truthiness, which was the previous behavior. For all other types, since there's no such commonly accepted way to coerce the type, it will fall back to the default setting for that property; previously, the behavior was undefined but most such mistakes would have caused the SDK to throw an exception at some later point.