This repository has been archived by the owner on May 30, 2024. It is now read-only.
prepare 5.13.1 release #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix "npm audit" warnings
# Conflicts: # package-lock.json
bump jest version to stop vulnerability warning
fix track() and identify() to reject missing/keyless user
# Conflicts: # package-lock.json
stop file data source from doing unnecessary reloads
many TS doc fixes and TypeDoc build script
increase event queue size to 10000
…kage remove request package; improve polling cache logic + add test
use launchdarkly-eventsource, make stream retry behavior consistent
# Conflicts: # package-lock.json
stream retry delay option should be in seconds & should be included in diagnostics
…tests close the store
don't call unref() on Redis client; ensure that database integration tests close the store
update Redis driver to major version 3
…-logger Fix/throw err on malformed logger
fix proxy tunnel configuration and make sure it's used in streaming
bwoskow-ld
approved these changes
Apr 24, 2020
LaunchDarklyCI
pushed a commit
that referenced
this pull request
Aug 27, 2020
retroactively update changelog for bugfix in 5.13.2 release
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[5.13.1] - 2020-04-24
Changed:
redispackage dependency has been updated to major version 3, which removes some deprecated usages (see #184) and adds support forrediss:URLs. This should not affect any application code even if the application is passing in a pre-built Redis client that was created with version 2.x, since the Redis methods that are used by the SDK have not changed.Fixed:
loggerwas either not a logger at all (that is, some other object that did not have the methods defined in theLDLoggerinterface), or was a broken logger that could throw an exception while the SDK was trying to log an error. The former case (not a logger) is now treated as a severely invalid configuration, causingLDClient.init()to throw an exception just as it would if the SDK key were omitted. The latter (logger method throws an exception) is now handled by catching the exception and logging an error message to the default console logger. (Thanks, maxwellgerber!)unref()on the Redis client object after creating it. This was originally done to ensure that the SDK client would not prevent an application from exiting due to a still-open Redis connection, but that is no longer applicable since the application must close the SDK client anyway before exiting, which will cause the Redis client to be closed as well. Theunref()call caused problems when running in Lambda, for unclear reasons. (#76)