This repository has been archived by the owner on May 30, 2024. It is now read-only.
Fix TestData.ifMatch rule matching #259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rule was not matching, after debugging it was found that the expected rule operator field was named `op` not `operator`. This was found by debugging until getting to the matchFn function in evaluator.js. There was also another issue where updating when using an ifMatch resulted in a JSON ref error. Replaced JSON based copy with manual copy:
LaunchDarklyReleaseBot
pushed a commit
that referenced
this pull request
Sep 6, 2022
…dardize-relay-proxy-in-daemon-mode-in Adds link to Relay Proxy docs
|
Released in 6.4.3. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rule was not matching, after debugging it was found that the expected rule operator field was named
opnotoperator. This was found by debugging until getting to the matchFn function inevaluator.js.There was also another issue where updating when using an ifMatch resulted in a JSON ref error. Replaced JSON based copy with manual copy.
Requirements
Related issues
#258
Describe the solution you've provided
This PR fixes the JSON circular ref by using a manual copy method in TestDataRuleBuilder rather than using JSON.stringify.
It fixes the rules not matching by using
oprather thanoperatorwhen usingTestDataRuleBuilder.andMatch