Skip to content
This repository has been archived by the owner on Oct 29, 2024. It is now read-only.

Enable initializing multiple clients #10

Closed
IsaacDurand opened this issue May 13, 2019 · 4 comments
Closed

Enable initializing multiple clients #10

IsaacDurand opened this issue May 13, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@IsaacDurand
Copy link

Is your feature request related to a problem? Please describe.
Yes. I'm working on an app that allows the user to toggle between multiple environments (staging, production, etc.). Each environment corresponds to a different database and a different LaunchDarkly environment with different targeting rules.

The problem I'm having is that the user gets "stuck" with the feature flag values for the first environment they select. For example, if the user chooses "production", the app initializes a LaunchDarkly client with the mobileKey for production. That way, the client provides the appropriate feature flag values for the production environment. However, if the user then toggles to the "staging" environment, the client still provides the feature flag values for production.

I attempted to create a different client for each environment, but when I tried to initialize a second client, I got an error: "Client was already initialized".

Describe the solution you'd like
I'd like to be able to create multiple client instances, just as I can with the Node SDK.

Describe alternatives you've considered
I can think of a couple alternate approaches:

  1. Allow the SDK user to destroy the existing client instance and create a new one to replace it
  2. Allow the SDK user to update the client configuration options (including mobileKey) for a client that's already been initialized

Either of these solutions would work for me as well. I'm not sure which of the three options is easiest to implement.

Additional context
I'm really enjoying working with this SDK - thanks so much for making it available!

@torchhound
Copy link
Contributor

Hi @IsaacDurand ! I'm glad you're enjoying the SDK. Multi-environment support is a feature in our Android and iOS V3 SDKs. Adding this feature to React Native and iOS V4 is on the roadmap. I can't give you an exact date but this should be live in the near future.

@torchhound torchhound added the enhancement New feature or request label May 13, 2019
@torchhound torchhound self-assigned this May 13, 2019
@IsaacDurand
Copy link
Author

Great news - thanks, @torchhound. I'll keep an eye out!

torchhound pushed a commit that referenced this issue Jun 27, 2019
commit a8266b095feb2738e198d782efcb695f92b68ce8
Author: Ben Woskow <bwoskow@launchdarkly.com>
Date:   Fri May 3 09:57:26 2019 -0700

    bump to 1.0.1

commit 349054698235229474fe42857cc0e0aecdaf94d0
Merge: 9902379 c9b1e32
Author: Ben Woskow <48036130+bwoskow-ld@users.noreply.github.com>
Date:   Fri May 3 09:44:39 2019 -0700

    Merge pull request #21 from launchdarkly/bw/36754/new-package-name-nr

    changing the package name

commit 9902379d63d1357a931d5cdac5c123e00c046bb1
Merge: bf7b70b e09bf57
Author: Ben Woskow <48036130+bwoskow-ld@users.noreply.github.com>
Date:   Fri May 3 09:40:15 2019 -0700

    Merge pull request #20 from launchdarkly/bw/ch36771/apply-markdown-templates-nr

    Applying markdown templates

commit c9b1e325adae850638a051c7ca4835d4475667d3
Author: Ben Woskow <bwoskow@launchdarkly.com>
Date:   Wed May 1 11:54:42 2019 -0700

    changing the package name to launchdarkly-react-native-client-sdk

commit e09bf57dfb7e8993d1fdf659fc18bfdef5ad98c8
Author: Ben Woskow <bwoskow@launchdarkly.com>
Date:   Thu May 2 17:06:52 2019 -0700

    doc updates

commit 139a6eae087ff80e50e14501ed69861142169bfe
Author: Ben Woskow <bwoskow@launchdarkly.com>
Date:   Wed May 1 11:52:10 2019 -0700

    fixing more references

commit 8964939d64b998bf11b5a0cba1599d726e877dcc
Author: Ben Woskow <bwoskow@launchdarkly.com>
Date:   Tue Apr 30 15:37:28 2019 -0700

    apply markdown templates

commit bf7b70bf467b7e2669da81859d7bd0ffbceb2cc0
Author: torchhound <5600929+torchhound@users.noreply.github.com>
Date:   Fri Apr 19 13:50:02 2019 -0700

    Updated CHANGELOG for 1.0.0

commit 88610ac3c2231b1f6522290076cac94a19ab4624
Author: torchhound <5600929+torchhound@users.noreply.github.com>
Date:   Wed Apr 17 16:25:09 2019 -0700

    Bump version to 1.0.0

commit 5c6d67df7bd232b6b0f81e2c0d0abcd4ffef062b
Author: torchhound <5600929+torchhound@users.noreply.github.com>
Date:   Wed Apr 17 14:50:47 2019 -0700

    Bumped Ndroid and iOS client versions

commit 747848ea0038594817a24009e187af3ba48efff9
Author: torchhound <5600929+torchhound@users.noreply.github.com>
Date:   Mon Apr 15 10:22:10 2019 -0700

    Closes #16 and #17

commit 502a573dda19984b7d4999a4879fa3251ca23175
Author: Eli Bishop <eli@launchdarkly.com>
Date:   Wed Mar 13 17:36:10 2019 -0700

    Update issue templates

commit a9db0d5f04440bb608c8d4c719c169ff4598a6e4
Merge: 888c530 7be58f8
Author: Joe Cieslik <unknownmasayoshi@gmail.com>
Date:   Mon Mar 4 18:14:43 2019 -0800

    Merge pull request #15 from launchdarkly/jc/ch33231/circleci

    Beta Release version 1.0.0-beta.1

commit 7be58f8b7ca6ab333b6c2efc589c75ff9c502309
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Mon Mar 4 14:52:56 2019 -0800

    chore(podspec, package.json): bump beta client version for release

commit a643f177de0054833275b90a96ccef155dd94670
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Mon Mar 4 14:51:36 2019 -0800

    fix(config.yml): prevent run-android from running forever

commit 647c9d25b54f3a93c0285eaf8c07eee349d7422c
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Mon Mar 4 14:35:55 2019 -0800

    fix(package.json, podspec): added react as peer dependency, added blob to podspec for source files

commit d692b953db076fdaf82a4a3dbe7959172313a866
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Fri Mar 1 11:18:10 2019 -0800

    feat(CHANGELOG, CONTRIBUTING, Podspec): added SWIFT_VERSION to podspec, added changelog and contributing

commit 0d040383e01f68324ac437cd60701d96b8246f2a
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Thu Feb 28 17:36:20 2019 -0800

    fix(config.yml): fix cd path

commit f1f0ad70fbd609ef1c90bcc4de5fd3e47db6d138
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Thu Feb 28 17:32:00 2019 -0800

    fix(config.yml): simplify cp command

commit 390bad53e4a38084bbfd4357c4658bc0ce8f6aa5
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Thu Feb 28 17:12:35 2019 -0800

    fix(config.yml): simpler project copy strategy

commit c41a737cd954db4b12625c830abd2705631a783c
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Thu Feb 28 17:07:09 2019 -0800

    fix(config.yml): added extended globs for negative match support

commit e59a97417036c833012ff8b717c3262e05cd1c1b
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Thu Feb 28 16:58:08 2019 -0800

    fix(config.yml, podspec): move podspec into ios/ to resolve errors, cp entire project into node_modules/ for testing

commit 06ddb0d928e7b96904ed8f4c843fb1e9a338343a
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Thu Feb 28 15:19:49 2019 -0800

    fix(config.yml): another github url fix

commit 4d8385c9cd8b5b2ad92dd7e7d77dd9a6b94c6d2c
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Thu Feb 28 15:14:41 2019 -0800

    fix(config.yml): fixed github hello app url

commit f95dfcd14c809d9ca876926ece96e8487350984c
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Thu Feb 28 15:11:31 2019 -0800

    fix(config.yml): added hello-react-native to fix circleci build test

commit 888c5308bcbb4cc5193e61aa01b4bef30d4129c1
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Thu Feb 28 11:46:48 2019 -0800

    fix(HelloReactNative/): remove HelloReactNative/

commit ab173c743847666b485057ae88dc3ddddf483cc3
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Thu Feb 28 11:38:44 2019 -0800

    feat(README, podspec, package.json): final details for release

commit 502b83195a630fa08e29f3b4e84f26b7b3f2b50c
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Thu Feb 28 10:06:07 2019 -0800

    fix(App.js): removed mobile key and staging env from Hello app

commit 8978f96d99e67e370daccdbe5abc60c84d8304c7
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Thu Feb 28 09:57:46 2019 -0800

    feat(LICENSE, Podfile, Podspec): added Apache 2.0 LICENSE, prepared podspec for beta, removed private from podfile

commit 83bdafa7ccbb5cb81e5a9e60c25b8d908015a79f
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Thu Feb 21 10:30:47 2019 -0800

    feat(README.md): prepare README for public release

commit 4600d395d6cad10dc6f1eaebbc96a826b9170cc6
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Thu Feb 14 09:55:51 2019 -0800

    fix(LaunchdarklyReactNativeClient.swift): added name parameter to user and change isAnonymous to anonymous

commit 8f8bfd3a9af4307de14a629e77b1d47230b3d463
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Thu Feb 7 10:03:22 2019 -0800

    feat(HelloReactNative/, build.gradle): update HelloReactNative and bump android client version

commit 6e6290b98095b6c6edfd5c7487e90b039e57eb3c
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Wed Feb 6 12:22:47 2019 -0800

    fix(config.yml): prevent run-android hang from failing test

commit f1cd846b2de44f3f5d3b1aa49857b1c5cae7d676
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Wed Feb 6 12:18:54 2019 -0800

    feat(LaunchdarklyReactNativeClient.swift): nil fallback values now work

commit 024e453c6d1dba9b72fe43130047d8964a65c599
Author: Gavin Whelan <gwhelan@launchdarkly.com>
Date:   Thu Jan 31 09:45:04 2019 -0800

    Changes for new trackEvent API.

commit 0ab09542f5b297253702f7241be8f87caabdc051
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Tue Jan 29 16:08:42 2019 -0800

    feat(.circleci/): added circleci config to confirm client builds and runs

commit bd2f0007e1a37b03e66648cd8020d2d366250c51
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Tue Jan 29 15:47:37 2019 -0800

    fix(LaucnhdarklyReactNativeClientModule.java): setOnline and setOffline now return promises for parity with iOS

commit 11709583b063d676472fddab525d182e364b1798
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Mon Jan 28 13:21:08 2019 -0800

    test(LaunchdarklyReactNativeClient.swift) testing final methods

commit 27b775c4fbcaf186ab85e4f60f8ccdd5a402d540
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Wed Jan 23 15:17:54 2019 -0800

    fix(index.js): remove Platform.select

commit 781b0e34428212e5bb5a6b6f5391245b77ea5e3e
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Wed Jan 23 11:14:51 2019 -0800

    feat(index.js, LaunchdarklyReactNativeClient.swift): switched if to Platform.select, added promises to set online and offline

commit 131c36079cbfba5b9b8ad9a5fa55c2c51ca9961c
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Thu Jan 17 16:04:09 2019 -0800

    feat(App.js, LaunchdarklyReactNativeClient.swift, Podfile): LD pod now points to master, added small testing changes to App.js, added nicer nil check to LaunchdarklyReactNativeClient.swift

commit 15bb82e94c2401350991c45060c07567f3a678c2
Author: Gavin Whelan <gwhelan@launchdarkly.com>
Date:   Mon Jan 14 17:30:29 2019 -0800

    Add mechanism for testing registering and unregistering more listeners.

commit df8d138139cfe641c8f97c8a233875ff7e3fc52a
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Mon Jan 14 16:14:08 2019 -0800

    feat(App.js, LaunchdarklyReactNativeClient.swift, index.js): added feature flag listener example to HelloReactNative, adding and removing feature flag listeners manually tested working

commit 08138fbf5b0d9de9e8e440cca062c131dbc0c8ef
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Mon Jan 14 11:58:58 2019 -0800

    feat(App.js, LaunchdarklyReactNativeClient.swift): feature flag listener testing

commit c9559faab46ee97998b41bd0c1caa2323d25f4fd
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Fri Jan 11 14:48:00 2019 -0800

    feat(LaunchdarklyReactNativeClient.swift): convert millis to seconds to reflect Swift config changes

commit 17438a8cfd39bb04431b18f29f1afef57267aba4
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Fri Jan 11 14:05:03 2019 -0800

    fix(LaunchdarklyReactNativeClient.swift): fixed weird dictionary conversion behavior for allFlags

commit c89e0c11e7689560355151d08e5fd9d8813da354
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Thu Jan 10 10:52:35 2019 -0800

    fix(App.js, Podfile, LaunchdarklyReactNativeClient.swift): switched Swift SDK branch to master_unthrottled, added all config options to HelloReactNative, removed most of the debug from swift client

commit 17efb6efb8f74aea80daf7b9739f036b35307796
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Wed Jan 9 17:26:35 2019 -0800

    feat(LaunchdarklyReactNativeClient.swift): added LDFlagChangeOwner reference tracking

commit 9b962ee078c82a10d9c9b344ee132fb238e18ec1
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Wed Jan 9 16:21:21 2019 -0800

    fix(App.js, LaunchdarklyReactNativeClient.swift, LaunchdarklyReactNativeClientBridge.m): fixed redundant identify, fixed setOnline objc bridge, debugging for setOnline issue

commit e4173e1c84804d1b66b3defbe2ae0e7a2ddc5261
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Tue Jan 8 16:29:11 2019 -0800

    fix(LaunchdarklyReactNativeClient.swift): changed identify and listener execution order

commit 0d59d78d9eb126ff4f1d3bf828295a3b0d032246
Author: torchhound <jcieslik@launchdarkly.com>
Date:   Tue Jan 8 14:50:37 2019 -0800

    fix(LaunchdarklyReactNativeClient.swift, LaunchdarklyReactNativeClientBridge.m): identify objc definition changed and added listeners for callbacks

commit d634ac37a22e635d6987e525618b159731546aa6
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Mon Dec 17 22:27:10 2018 -0500

    fix(LaunchdarklyReactNativeClient.swift): added necessary nil check in ternary for streamingMode

commit 99e0efe68d9ebb2637702f46c6c4138fb0f3bda3
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Mon Dec 17 22:03:00 2018 -0500

    fix(LaunchdarklyReactNativeClient.swift): streamingMode is an enum not a boolean

commit 4327ba47b5740946c29405f4ba460d1afa20bd6b
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Sun Dec 16 23:31:40 2018 -0500

    fix(LaunchdarklyReactNativeClient.swift): fixed configure issues, removed unnecessary underscores, HelloReactNative works for iOS

commit 736ef203b592e7642a9bb1d45ced3a2d9af08fe3
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Mon Dec 17 01:56:39 2018 +0000

    Missing typeof caused issue in handling track calls without data.

commit 593512e1a00a100115353e3acb7d9fbd6812127c
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Sat Dec 15 21:44:20 2018 +0000

    Fix unregistering flag listener and code consistency improvements.

commit 52b055842b2fb46619c339f4da666d89554febc4
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Sat Dec 15 16:08:50 2018 -0500

    refactor(README.md, LaunchdarklyReactNativeClient.swift): minor changes to access and cleanup

commit 68a1fbc10cddafaeb9732df3897cc8f9aabd5f9b
Merge: e503317 ac68bed
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Sat Dec 15 19:49:43 2018 +0000

    Merge branch 'master' of github.com:launchdarkly/react-native-client-private

commit e503317a472634de32817402db97cece07c5c3cb
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Sat Dec 15 19:48:46 2018 +0000

    Split out ui handler code and remove old subscription structure.

commit ac68bed05c0d4a293f8d4587c3c5da02f06a13f6
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Fri Dec 14 21:23:56 2018 -0500

    feat(LaunchdarklyReactNativeClient.swift): added allFlags, private, and custom support, needs testing

commit 5174ef48b12de7450454215c90a305c3d02b6e06
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Fri Dec 14 20:41:44 2018 +0000

    Add missing user ip configuration, and handle Android SDK's
    inconsistency with eventsUri.

commit dda34bbe9966b7b0dcedd28c36447d66dbf50a36
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Sat Dec 8 01:33:44 2018 +0000

    Explicitly handle null and undefined fallback values, as the react
    native bridge seems to handle them unreliably.

commit 24edd4220f0e9563e0995d6b56fa3ce49c6e8eaf
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Sat Dec 8 00:09:59 2018 +0000

    Handle multiple listeners per flag key.

commit b903ffa667de9c0009b777b7368993c436950726
Merge: 905b9a0 7b16e2a
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Fri Dec 7 23:02:51 2018 +0000

    Merge branch 'master' of github.com:launchdarkly/react-native-client-private

commit 905b9a0224f83ba83f2bb18a1dabf8cb5b981917
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Fri Dec 7 23:02:25 2018 +0000

    Javadoc updates.

commit 7b16e2ac7a9fe2142203c0fa519962c06277ff3a
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Fri Dec 7 14:04:37 2018 -0500

    Updated swift sdk pod, support new react bridge calls

commit 1d74f908e8d9b8ffe7bb71e7497cd96f61d626c1
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Thu Dec 6 15:59:26 2018 -0500

    Added unregisterFeatureFlagListener

commit b8904342558dcf9f3319705e194657be9942f18f
Merge: 2457cab f862d04
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Thu Dec 6 13:40:49 2018 -0500

    Merge branch 'master' of https://github.com/launchdarkly/react-native-client-private

commit 2457cabcc231f96893bed3557b40e6376b4ec2f0
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Thu Dec 6 13:40:39 2018 -0500

    Fixed flush and identify, renamed in swift sdk

commit f862d0446c6cf05ade45ae0e6ecc3e69261ed166
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Thu Dec 6 18:35:15 2018 +0000

    Fix redundant linking.

commit 8a68c31479c356380d31df6523c666798ad10b64
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Thu Dec 6 13:30:11 2018 -0500

    Fixed registerFeatureFlagListener

commit 81cffe7f6203a157a5e9f47985dc4cbf8dc8ada2
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Thu Dec 6 13:06:46 2018 -0500

    Removed HelloReactNative/ios-backup

commit 8380fb74416290b151800541a4b5df2cc4d560be
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Thu Dec 6 12:00:37 2018 -0500

    Magic build fixes vi Gavin, now to fix implementation details

commit f318071feb49e3ddeb889678a98e4c7698d09fca
Merge: 050007f 5dd75f0
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Thu Dec 6 12:20:23 2018 +0000

    Merge branch 'master' of github.com:launchdarkly/react-native-client-private

commit 050007f24c594f5983ef663edd12ce8419acf9b4
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Thu Dec 6 12:19:01 2018 +0000

    Minor event changes and substantial user configuration changes
    for #2, #4, and #10.

commit 5dd75f0957df99d5f62684290bfe1adcc63a15f8
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Wed Dec 5 20:26:46 2018 -0500

    Changed syntax

commit b50050bc9c2efa65c85d3742ce6b88e075943d6e
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Wed Dec 5 19:29:52 2018 -0500

    Fixed FFI syntax

commit 838ad219b8af21037ead0312cbb24a3ef7eff81f
Merge: 7ff0df8 c107bb6
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Wed Dec 5 19:03:49 2018 -0500

    Merge branch 'master' of https://github.com/launchdarkly/react-native-client-private

commit 7ff0df80c86af0a2eb7ebf58d1624195f1ce6d0b
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Wed Dec 5 19:03:21 2018 -0500

    Massive changes from gavin

commit 3803d5a3411949047e6507bb6a9ddde90f79427b
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Wed Dec 5 16:03:50 2018 -0500

    Remove tvOS project directories.

commit c107bb69384d107e9e9bcdb1b81f0989f8181e73
Merge: bf912c4 85ceda5
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Wed Dec 5 20:08:38 2018 +0000

    Merge branch 'master' of github.com:launchdarkly/react-native-client-private

commit bf912c450eaa1e9f58d8e70e844395684d8a3c9e
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Wed Dec 5 20:05:59 2018 +0000

    Move waiting on future for configure and identify to explicit
    background thread. Dispatch on data type in JavaScript module code to
    type dependent methods for track and jsonVariation to allow support
    for json arrays and primitives due to lack of @ReactMethod binding
    polymorphism.

commit 85ceda5b5673a4df0330e3f8a80852153084cd74
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Wed Dec 5 14:19:07 2018 -0500

    Forgot index.js native event emitter changes

commit d1a44143c2ea3ff70956d79a8c70150c32d971de
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Wed Dec 5 14:17:06 2018 -0500

    Fixed build, issue seesm to be with the NativeEventEmitter, added code to support that

commit 15544913be1489004ff32976887e36eae20eaafa
Merge: 2830a1a 21e0a0b
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Wed Dec 5 13:01:30 2018 -0500

    Merge branch 'master' of https://github.com/launchdarkly/react-native-client-private

commit 2830a1a89b8908be66f9b151f6ba8e7ae0d8f6b4
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Wed Dec 5 13:01:17 2018 -0500

    Small build changes

commit 21e0a0b60e59f21768a7345dcef3878714abef66
Merge: 512b2da a429b65
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Wed Dec 5 01:16:29 2018 +0000

    Merge branch 'master' of github.com:launchdarkly/react-native-client-private

commit 512b2daf9a68b72b3fa2ce6a491e0bc1f7fa9a17
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Wed Dec 5 01:15:46 2018 +0000

    Fix some of the issues with jsonVariation.

commit a429b65903c3c609cef96d16dab2e94c14f475d1
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Tue Dec 4 20:12:37 2018 -0500

    Added more paths, xcode transformed the framework search path and instead of being empty or containing /../../../ios/Pods it contains paths to LaunchDarkly and DarklyEventSource

commit 001515c28310940ef0612e3dca8a276bbaef54f0
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Tue Dec 4 20:07:05 2018 -0500

    Added framework search path

commit 159554e176e376e8f08153d65a7c9b1ff494147e
Merge: c00c5a4 8aa344c
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Tue Dec 4 19:58:40 2018 -0500

    Merge branch 'master' of https://github.com/launchdarkly/react-native-client-private

commit c00c5a494ed79d49483b7296034baf1fca879d9c
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Tue Dec 4 19:58:28 2018 -0500

    More workspace path

commit 8aa344c12f3d1bdd9366ebe6e3da15caccf6a4c7
Merge: a7a1b52 b2d4b98
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Wed Dec 5 00:56:55 2018 +0000

    Merge branch 'master' of github.com:launchdarkly/react-native-client-private

commit a7a1b524e370d17f2973e8ae5b4892ea00243a4a
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Wed Dec 5 00:55:13 2018 +0000

    More cleanup and comments. Change variations to resolve with fallback
    on error. Change track on JS side to support being called with or
    without data.

commit b2d4b98dcea31389c732fe7587570ca233e1cf7b
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Tue Dec 4 19:34:56 2018 -0500

    Files from last commit

commit ed17f454bc41f7b7fa61aa0e6a0e083204bb86b9
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Tue Dec 4 19:31:00 2018 -0500

    Added relative path to ios/Pods

commit eb76e7d258899a3f2a62bf941c9c94ca533e8724
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Tue Dec 4 18:40:12 2018 -0500

    Podfile changes

commit 1dd1842f10cfa09230eefc147dab21b2d823f06f
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Tue Dec 4 18:13:30 2018 -0500

    Try alternate import syntax, build system is confirmed pulling in React dependencies

commit 75fcd615a9e0f022534c82ed57c01af395655529
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Tue Dec 4 18:05:01 2018 -0500

    More swift dependency

commit 4978ee3d6650348300235bda368461128c26008b
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Tue Dec 4 16:05:17 2018 -0500

    Added Darkly.h

commit 55068c3de4dd65d0e2889e73bc79a8a9f59814a8
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Tue Dec 4 18:52:18 2018 +0000

    Somehow duplicate code got in and broke things.

commit d36b0616c58467251c6526ca1b263e78ea3fd952
Merge: 4fb223b 58b8fd6
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Tue Dec 4 18:45:13 2018 +0000

    Merge branch 'master' of github.com:launchdarkly/react-native-client-private

commit 4fb223b7431ccd8779537d96cd2048e891fd6982
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Tue Dec 4 18:43:01 2018 +0000

    Add promise to identify for handling user build failure. Improve error
    handling in some cases. Add a bunch of comments.

commit 58b8fd66e5e4212b31ba375c7317d30a82d9808d
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Tue Dec 4 13:26:06 2018 -0500

    Linked LD swift into ios

commit 8c71a71003736b124870543024278706ff115321
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Tue Dec 4 13:19:42 2018 -0500

    Trying to fix LD swift module null

commit bce9161adbfb6db090d3980e0e4713aab27a8300
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Tue Dec 4 13:10:24 2018 -0500

    Commit pods for consistent dependencies

commit e52cf87dc586a0c7b72dfc4dc671d18c6e3a9d70
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Tue Dec 4 13:00:40 2018 -0500

    More swift work and cleanup

commit c0132c86c43b48d93113a784e0637fb7cd4e4e82
Merge: 0e62ec1 d82027c
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Mon Dec 3 20:37:57 2018 -0500

    Merge branch 'master' of https://github.com/launchdarkly/react-native-client-private

commit 0e62ec1c2d882cab9c7b696426c90607eac3cd20
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Mon Dec 3 20:37:32 2018 -0500

    Added promises, cleaned up ios

commit d82027c5f829053488b1acbe77e035e9faff29b7
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Tue Dec 4 01:31:54 2018 +0000

    Accidentally was missing a semicolon...

commit 7a8de5c530d52c1add5d3e16ac7bced9ccc5a582
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Tue Dec 4 01:29:52 2018 +0000

    User the same framework for User configuration.

commit f6c29f1cd43c3aa8d47a2eceeb4cd5d32e698273
Merge: cc657d9 f12e22c
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Tue Dec 4 01:08:09 2018 +0000

    Merge branch 'master' of github.com:launchdarkly/react-native-client-private

commit cc657d9851b0a26dbb090c49cbf1b93d024eaf70
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Tue Dec 4 01:06:29 2018 +0000

    Trying new configuration loading system.

commit f12e22c4e326a35f1fa50901f39b59b3aec19b2d
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Mon Dec 3 18:19:17 2018 -0500

    Switched ios to Swift sdk using git, removed example

commit 5f7f9a707865cc51c762dae07f29a0387b283be8
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Mon Dec 3 22:39:38 2018 +0000

    Small bug fixes.

commit 2108d04d8fee17be31ea742c9b83b8c98e79c4f9
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Mon Dec 3 22:22:46 2018 +0000

    Make sure to pass argument to identify.

commit 905b5a43ffb098f4c954d0c50a936df2af1e22cb
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Mon Dec 3 22:10:50 2018 +0000

    Return promises form variation calls.

commit c6022b25f8270b391338ab0877d4c198699b1d73
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Mon Dec 3 21:45:33 2018 +0000

    Change how client configuration works.

commit 4207eb24df1ecd1dfaf7ab76f4c21af4e212c70a
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Mon Dec 3 19:57:28 2018 +0000

    Am I crazy?

commit 3edbc31c914d832ef1e268b040294e6326d5b542
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Mon Dec 3 18:02:52 2018 +0000

    Export named class.

commit 951afce8eba3c6e3f618e4d91001a4c317e16499
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Mon Dec 3 17:58:57 2018 +0000

    Export default singleton.

commit bdaf720e60c65ce93c6b85a57d7c2b06b05acb5b
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Mon Dec 3 17:50:54 2018 +0000

    Export module class differently.

commit 3c13accd694bc2d836b9139860f3d0208dd501ff
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Mon Dec 3 17:36:52 2018 +0000

    Making sure code is actually being updated.

commit 4d12e14963f7e17c80eb1fc78e13b5768a3490bc
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Mon Dec 3 17:30:28 2018 +0000

    Add some logging to test something.

commit a4721cdea2a9455cc2126f314af6a1c734997480
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Mon Dec 3 01:24:04 2018 +0000

    Return promise from configure.

commit 49506a01bf9b697ad0e98482d5972b8b9cfa2e6f
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Sun Dec 2 19:28:06 2018 +0000

    Push in other testing code.

commit 245a02d8470638567c00244ccbfdfe833f608a09
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Sun Dec 2 09:40:30 2018 +0000

    Try a thing.

commit 712da6c71474be3f3eec9257ba1b05aedb031109
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Sat Dec 1 23:16:07 2018 +0000

    Try changing native module extraction.

commit 3324b9e33a4d7cf8842df660f6267f61d175cefe
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Sat Dec 1 23:07:32 2018 +0000

    Was using promises wrong.

commit 5d14752cbc4c204a26c08c04e9aba99860f516ab
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Sat Dec 1 22:46:32 2018 +0000

    More integration of promises.

commit aedda50d0163c36083b25b4ea48b52abb946b5eb
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Sat Dec 1 22:34:30 2018 +0000

    Handle a bunch of bridge translation cases.

commit c98bf6ab2aee4d96bc132c39a53634f10b899ad9
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Sat Dec 1 21:34:18 2018 +0000

    Start using promises.

commit fc8f267e1f47d931f4aa5d5d9434b0e185d8e1af
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Sat Dec 1 21:12:48 2018 +0000

    Trying to confirm constructor is run.

commit 789adc73c025666aa4c22806204c6c35aa57cdee
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Sat Dec 1 20:52:48 2018 +0000

    Return name to something reasonable.

commit c74cd60ec96dd7e21cf2c3e3259916124fcbfc2a
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Sat Dec 1 20:41:52 2018 +0000

    Testing package resolution fixes.

commit dd346d99b74b96b71cf458731c80c99c13ee7b97
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Tue Nov 20 05:15:47 2018 +0000

    Accidental paste ruined commit.

commit 314860ddabe2550631ce270003ebd7a4eb83642d
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Tue Nov 20 05:13:20 2018 +0000

    Change code formatting. Now is Android Studio standard.

commit e519c35d089b408ab144f7e822c53d8a4e24736c
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Tue Nov 20 04:15:32 2018 +0000

    Buttons don't have style prop.

commit 3c9f75fe49c7c26f99a4126f64cc7ddb3e75bdd0
Author: Gavin Whelan <gavwhela@gmail.com>
Date:   Tue Nov 20 04:04:41 2018 +0000

    Remove trailing whitespace from example App.js

commit 51390ae261d888716adf4e6b3434537c8b47a439
Author: torchhound <unknownmasayoshi@gmail.com>
Date:   Sun Nov 18 19:56:45 2018 -0500

    Added example react native app, UI is finished needs client calls, unfortunately react native doesn't allow importing from a parent directory

commit d97b6d5aa578aac2fa27d84dc12afeeaf0eb5dfa
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Sat Nov 17 18:16:42 2018 -0500

    Added allFlags and registerFeatureFlagListener to iOS

commit 3f9031195a28a95040f6682626dce5ac0a92d7d6
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Thu Nov 15 21:28:45 2018 -0500

    Added most of the swift code and obj c bridge, not sure about RCT_EXTERN_METHOD return types, added privateAttributes to android and js configure

commit 198f3689afab896769a134822396609cea637749
Author: torchhound <unknownmasayoshi@gmail.com>
Date:   Mon Nov 12 15:55:02 2018 -0500

    Added some fixes for linting and listeners in JS

commit 55d65dfbaf79c8217bb1b49f4807257199f48228
Author: torchhound <jcieslik@umail.iu.edu>
Date:   Mon Nov 12 13:34:34 2018 -0500

    Started work on iOS, added swift and obj c bridging code

commit e91b0b2232db6801abce87d5c72a202c7a6931ed
Author: torchhound <unknownmasayoshi@gmail.com>
Date:   Sun Nov 11 18:29:43 2018 -0500

    Added feature flag listeners, added returns for methods that have a return type, removed unnecessary get()

commit e129c79b3da3a945d2150fa81094bfe6f52cbfeb
Author: torchhound <unknownmasayoshi@gmail.com>
Date:   Sun Nov 11 17:24:09 2018 -0500

    Added js code, removed unnecessary synchronized

commit 799f53160eab8a5570406401717ca511d5dd1181
Author: torchhound <unknownmasayoshi@gmail.com>
Date:   Sun Nov 11 16:55:58 2018 -0500

    Added all of the Android methods except feature flag listener

commit 1d0bf362f9014c7fd48aa1d8d0896d359d54cc2f
Author: torchhound <unknownmasayoshi@gmail.com>
Date:   Sat Nov 10 18:34:28 2018 -0500

    Added react native library structure
@torchhound
Copy link
Contributor

Hi @IsaacDurand multiple environments is now available in SDK version 4.2.0.

@IsaacDurand
Copy link
Author

Awesome - thanks for the update, @torchhound!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants