prepare 7.3.0 release #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add event payload ID header
(6.0) drop support for old Ruby versions
remove rake dependency
update ruby-eventsource to 1.0.3 for backoff bug
fix incorrect initialization of EventProcessor
…heck remove install-time openssl check that breaks if you don't have rake
fail fast for nil SDK key when appropriate
* Only shutdown a Redis pool created by SDK * Make pool shutdown behavior an option
When we introduced models for the flag and segment data, we added to_json methods which proxy to the underlying to_json method provided by the `json` gem. We defined the method with a variadic parameter, but we failed to unpack it when passing it on to the underlying implementation. This resulted in a serialization failure which prevented the redis data store from initializing.
The underlying event source library had an issue where, in certain environments, content-type header detection was failing. This was resolved in v2.2.2 of the event source gem.
The client instance will now provide access to a `data_source_status_provider`. This provider allows developers to retrieve the status of the SDK on demand, or asynchronously by registering listeners.
The full unit test suite includes tests relying on externally instances of Redis, Consult, and DynamoDB. By default, we do not want to run these tests. Rather, they should be opt-in by setting the environment variable `LD_SKIP_DATABASE_TESTS=0`.
The client instance will now provide access to a `flag_tracker`. This tracker allows developers to be notified when a flag configuration changes (or optionally when the /value/ of a flag changes for a particular context).
The client instance will now provide access to a `data_store_status_provider`. This provider allows developers to retrieve the data store status of the SDK on demand, or asynchronously by registering listeners.
This commit includes multiple small refactors to clean up the code or otherwise improvement the development experience. Larger changes: - Each test is now wrapped in the matching module under test. This eliminates a lot of repetitive namespace navigation. - A few test files were moved to new directories. This ensures the spec location matches the location of the unit under test. Small tweaks: - Reduce usage of global variables - Remove unnecessary then from multi-line unless / end block - Fix http reference in rubocop file - Remove spaces before opening parenthesis - Do not include () if no arguments passed - Prefer %w for bare word arrays - Empty rescues should have an explicit comment - Remove unused variables and fix naming conventions
Webrick seems to struggle when running on JRuby. I suspect this because of the global lock in standard ruby but I don't know for sure. Either way, having tests fail randomly is no way to live so I am disabling them in JRuby. I don't think this is a huge concern because - The same tests are run in other rubies, so we know the coded logic is sound. - The failures don't originate from our code -- rather, they seem to come from the mock server, so no important code is being left untested.
louis-launchdarkly
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[7.3.0] - 2023-10-16
Fixed:
default_connect_timeoutsetting stated it defaulted to 10 seconds when the code actually defaults to 2. (Thanks, zmagg-figma!)Deprecated:
LDContextusing the legacy user format has been deprecated and will be removed in the next major release. To learn more, read the Contexts documentation.