Jko/user rules #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
| return false | ||
| end | ||
|
|
||
| def match_variation?(variation, user) |
There was a problem hiding this comment.
Since the userTarget is a part of the variation, this function should probably be named matchTargets or something, since it a user may match a given variation, but this function would return false.
I guess it doesn't matter that much, since this function is private anyway...
There was a problem hiding this comment.
Yeah, some of the names are a bit unfortunate, but I want to keep the SDKs as consistent as I can. It makes it easier to port code between them. So I'd rather not have to re-name this everywhere.
|
lgtm |
zsiddique
added a commit
that referenced
this pull request
Jul 26, 2017
* gitignore DS_Store * Update readme with note on how to install via gem command * Update grammar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.