Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank screen when leaving the app then coming back #11264

Closed
jasonwilliams opened this issue Oct 26, 2024 · 8 comments · Fixed by #11514
Closed

Blank screen when leaving the app then coming back #11264

jasonwilliams opened this issue Oct 26, 2024 · 8 comments · Fixed by #11514
Assignees
Labels
bug It's a bug high High priority issues mobile All mobile platforms

Comments

@jasonwilliams
Copy link
Contributor

jasonwilliams commented Oct 26, 2024

Operating system

iOS

Joplin version

13.0.7

Desktop version info

No response

Current behaviour

  1. Open a note (any note)
  2. Swipe up to leave the app and navigate to another app
  3. Come back
  4. You now have a blank screen

Expected behaviour

  1. Open a note (any note)
  2. Swipe up to leave the app and navigate to another app
  3. Come back
  4. You come back to the note you were on

This could be related to #11197 but this is happening on iOS and you don’t need to restart the phone for it to happen.

Also after some messing around, it only seems not all notes do it, one or two will persist, but the majority of them turn blank when leaving the app.

In the video below, just the act of swiping up alone blanks out the screen.
https://github.com/user-attachments/assets/e390c17d-9b37-4e48-8bce-3337c36c2a77

iOS 17

Logs

No response

@jasonwilliams jasonwilliams added the bug It's a bug label Oct 26, 2024
@bsavant
Copy link

bsavant commented Oct 28, 2024

I can reproduce this consistently when you search, and the note you select is not in the current notebook. iOS 18, Joplin 13.1.5

@dejafait
Copy link

dejafait commented Nov 2, 2024

This is happening to me as well on Android.

@personalizedrefrigerator personalizedrefrigerator added mobile All mobile platforms high High priority issues labels Nov 4, 2024
@personalizedrefrigerator
Copy link
Collaborator

I'm linking to the commit that resolved #9204. It should be in Android v3.1.7.

@GonzRon
Copy link

GonzRon commented Nov 5, 2024

@personalizedrefrigerator I don't know if the commit you linked resolved #9204, after all the issue is still recurring in latest android version 3.1.7. I think you may be referencing a different fix since I see the following. So two separate issues two different commits.

[root@ganymede joplin]# git tag --contains 2fc9bd476b0d9abcddb0a46f615a48333779d225
[root@ganymede joplin]# git branch --contains 2fc9bd476b0d9abcddb0a46f615a48333779d225
  contains
* dev

@Petemir
Copy link
Contributor

Petemir commented Nov 6, 2024

I can reproduce this consistently when you search, and the note you select is not in the current notebook. iOS 18, Joplin 13.1.5

Just want to add that also activating Siri (Hey Siri) blanks the screen (after following the quoted steps)

@dejafait
Copy link

dejafait commented Dec 5, 2024

Still happens on 3.2.2 Android fyi.

@personalizedrefrigerator
Copy link
Collaborator

personalizedrefrigerator commented Dec 14, 2024

Still happens on 3.2.2 Android fyi.

Thank you for noticing! That may be related to an incorrectly resolved conflict in this merge commit.

In release-3.1, where a fix was originally merged, noteId={noteId} overrides the noteId specified in props:

<NoteScreenComponent key={noteId} {...props} noteId={noteId} />

This change was made such that the note editor would continue to render the last-seen note id, even if props.noteId became null. This could happen if the note selection was cleared.

In dev, notice that noteId no longer overrides the noteId specified in props:

<NoteScreenComponent key={noteId} dialogs={dialogs} {...props} />

As a result, clearing the selection would still cause the note editor to edit nothing.

@jasonwilliams
Copy link
Contributor Author

I don't know if you've already pushed a release out but I don't notice this anymore, thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug high High priority issues mobile All mobile platforms
Projects
None yet
6 participants