Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicating a note containing a bulleted list with an image destroys the list formatting #11382

Closed
L1ghtmann opened this issue Nov 11, 2024 · 7 comments · Fixed by #11532
Closed
Assignees
Labels
bug It's a bug editor high High priority issues

Comments

@L1ghtmann
Copy link

Operating system

Windows

Joplin version

3.1.24

Desktop version info

Joplin 3.1.24 (prod, win32)

Client ID: 13d5227f980241778ad5562f8f944732
Sync Version: 3
Profile Version: 47
Keychain Supported: Yes

Revision: d581264

macOS theme: 1.5.7

Current behaviour

Create a note with a list:
{CCB4FC40-8DD0-4EB6-8AC6-63A789DE3D84}
Duplicate the note
Observe change to formatting to BOTH the original note and the duplicate:
{D42CD7E9-61DF-4E44-B8CE-03EF57EA573D}

Note that this does NOT occur if the list does not contain an image

Expected behaviour

The formatting to be retained

Logs

No response

@L1ghtmann L1ghtmann added the bug It's a bug label Nov 11, 2024
@personalizedrefrigerator
Copy link
Collaborator

I can reproduce this in Joplin 3.2.1 — it seems that if a list item contains only a user-resized (HTML) image, following list items are merged onto the same line when rendering.

In particular if I,

  1. Create a note containing a bulleted list in the Rich Text Editor.
  2. Add an image as the first list item.
  3. Resize the image by dragging one of the resize handles.
  4. Add new sub-list-items below the first item.
  5. Switch to the Markdown viewer.
  6. Switch back to the Rich Text Editor,

I can reproduce this issue.

@personalizedrefrigerator personalizedrefrigerator added editor high High priority issues labels Nov 11, 2024
@VANSH3104
Copy link

@personalizedrefrigerator I also generate this bug it only happens with bulletlist not with numbered list and squared list I also check the pasted list statement too it is same in all case I am working on this issue

@L1ghtmann
Copy link
Author

Really appreciate your guys' speedy assistance with this!

I'm unsure if it's also related to resource handling, but I encountered #11373 recently. Just figured I'd mention in the event they were similar underlying problems. Thanks again!

@VANSH3104
Copy link

@L1ghtmann yes i also think that it is related

@VANSH3104
Copy link

"Hi @laurent22, I have some doubts related to this issue. I messaged you on Discord. Could you please check?"

@personalizedrefrigerator
Copy link
Collaborator

It seems that if a list has markup similar to the following,

- <img src=":/fa188ce561be4f7f9e7541a1fe4b1341"/>
    - Test

then markdown-it renders the list as
screenshot: First list item included on same line as image

Note that GitHub renders the list in a similar way.

To prevent the next line from becoming a continuation of the first, it seems necessary to add a closing tag or other content after the <img ... />. For example,

- <img src=":/fa188ce561be4f7f9e7541a1fe4b1341"></img>
    - Test

@L1ghtmann
Copy link
Author

Really appreciate you looking into this! I've been meaning to learn TS so I could take a crack myself, but been really busy lately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment