Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rotation of attached image is lost when the image is resized #9597

Closed
laurent22 opened this issue Dec 24, 2023 · 2 comments · Fixed by #9824
Closed

Rotation of attached image is lost when the image is resized #9597

laurent22 opened this issue Dec 24, 2023 · 2 comments · Fixed by #9824
Assignees
@personalizedrefrigerator
Labels
bug It's a bug desktop All desktop platforms editor high High priority issues

Comments

@laurent22
Copy link
Owner

Operating system

Windows

Joplin version

2.13.0

Desktop version info

No response

Current behaviour

  • Drag and drop the below image on the RTE
  • Don't choose to resize it

=> The rotation is preserved

  • Drag and drop the below image on the RTE
  • Choose to have it resized

=> The rotation is lost (image is displayed in landscape mode instead of portrait)

20231224_142837.jpg.zip

The same issue may be happening on mobile too, so it should be checked

Expected behaviour

No response

Logs

No response
@laurent22 laurent22 added bug It's a bug desktop All desktop platforms editor high High priority issues labels Dec 24, 2023
@personalizedrefrigerator
Copy link
Collaborator

Related: #8310

Open
personalizedrefrigerator added a commit to personalizedrefrigerator/joplin that referenced this issue Jan 29, 2024
@personalizedrefrigerator
Desktop: Fixes laurent22#9597: Fix rotation sometimes lost when resiz…
a9e9a35 
…ing images

This switches to DOM APIs for resizing images -- the nativeImage API
loses rotation metadata.
@personalizedrefrigerator
Copy link
Collaborator

personalizedrefrigerator commented Jan 31, 2024 •
edited
Loading

I'm uploading another test image for use in creating an upstream bug report:

testing.jpg.gz

This is the Electron Fiddle I plan to use to report the bug upstream.

Closed
3 tasks
personalizedrefrigerator added a commit to personalizedrefrigerator/joplin that referenced this issue Jan 31, 2024
@personalizedrefrigerator
Desktop: Fixes laurent22#9597: Fix rotation sometimes lost when resiz…
4678466 
…ing images

This switches to DOM APIs for resizing images -- the nativeImage API
loses rotation metadata.
personalizedrefrigerator added a commit to personalizedrefrigerator/joplin that referenced this issue Feb 2, 2024
@personalizedrefrigerator
Desktop: Fixes laurent22#9597: Fix rotation sometimes lost when resiz…
425c98f 
…ing images

This switches to DOM APIs for resizing images -- the nativeImage API
loses rotation metadata.
Merged
laurent22 pushed a commit that referenced this issue Feb 2, 2024
@personalizedrefrigerator
Desktop: Fixes #9597: Fix image rotation not preserved when resizing …
a0f003f 
…an attached image (#9824)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@personalizedrefrigerator personalizedrefrigerator

Labels
bug It's a bug desktop All desktop platforms editor high High priority issues
Projects
None yet
Milestone
No milestone
2 participants
@laurent22 @personalizedrefrigerator