Desktop: Improve focus handling for notebook edit, share, and sync dialogs #10779
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request switches many dialogs to the HTML
<dialog>
element, which:autofocus
attribute to a different element).Tab
no longer causes focus to leave the dialog.Testing plan
Enter
always accepts the same button and closes the dialog, regardless of keyboard focus (unless in atextarea
). (Code that causes the issue).This has been tested successfully on Ubuntu 24.04.