Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Fixes #11183: Fix new note/edit buttons only work if pressed quickly #11185

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Oct 7, 2024

Summary

This pull request fixes #11183 by increasing the long press delay to 10s. Joplin currently doesn't use the long press event, so it should be safe to set this to a large value.

Note: A built version of this pull request has been deployed to https://personalizedrefrigerator.github.io/joplin/web-client/ .

Testing plan

Android 13:

  1. Open a folder.
  2. Quickly tap the "+" button.
  3. Verify that this opens the "new to-do"/"new note" menu.
  4. Tap and hold the "x" button for roughly 2s.
  5. Verify that the menu closes when the gesture ends.
  6. Tap and hold the "+" button for roughly 2s.
  7. Verify that the "new note"/"new to-do" menu opens.
  8. Tap and hold "new note" for roughly 1s.
  9. Verify that a new note is opened in the editor.
  10. Enter a title and open the note viewer.
  11. Tap and hold the edit button for roughly 4s.
  12. Verify that releasing the button switches to edit mode.

@laurent22 laurent22 merged commit 349fa42 into laurent22:dev Oct 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile: The "+" button doesn't work if pressed too slowly
2 participants