Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop,Mobile: Add setting to disable markup autocompletion #11222

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Oct 16, 2024

Summary

This pull request adds a setting to disable markup autocompletion, as requested on the forum.

Note

This pull request builds on #11221 — a new CodeMirror API is required to disable HTML tag autocomplete.

Screen recording

Screencast.from.2024-10-16.08-29-41.webm

Note: The screen recording shows the new setting with a different label. The setting label was changed in 3f1d42b.

Testing plan

Desktop (Fedora 40) and Android 13:

  1. Disable markup autocomplete in settings > note > advanced.
  2. Type:
    1. this
    2. is
    3. a
    4. test
    
    and verify that list numbers are not inserted automatically after pressing enter.
  3. Press enter.
  4. Type <div>.
  5. Verify that a </div> closing tag was not inserted automatically.
  6. Close the <div>.
  7. Add two new lines and type (.
  8. Desktop only: Verify that a closing ) has been inserted.
    • Automatch brackets is a separate setting.
  9. Desktop only: Disable braces automatch and enable HTML autocomplete.
  10. Move the cursor to the end of the 2nd list item.
  11. On desktop, Press tab. If on mobile, press the indent button.
  12. Verify that the list item has been indented and renumbered (1. instead of 2.).
  13. Desktop only: Near the end of the note, type (. Verify that no closing ) is added.
  14. On a new line, type <div>. Verify that a closing </div> is added.

@laurent22 laurent22 merged commit 92c13c2 into laurent22:dev Oct 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants