Desktop: Fix error screen shown on opening settings when an incompatible plugin is installed #11223
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes a bug where the "Joplin encountered a fatal error" screen would be shown on opening settings, if an incompatible plugin was installed.
See https://discourse.joplinapp.org/t/fatal-error-when-updating-to-v3-1-18/41392
Note
This pull request targets
release-3.1
.Cause
PluginBox.tsx
usedprops.manifest
instead ofitem.manifest
to generate an incompatibility message. However,props.manifest
is only defined while searching for plugins.Testing plan
Note
These are the steps I've taken locally to manually check for related regressions and verify that the issue has been resolved.
packages/app-desktop/package.json
.code
".