Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fix error screen shown on opening settings when an incompatible plugin is installed #11223

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Oct 17, 2024

Summary

This pull request fixes a bug where the "Joplin encountered a fatal error" screen would be shown on opening settings, if an incompatible plugin was installed.

See https://discourse.joplinapp.org/t/fatal-error-when-updating-to-v3-1-18/41392

Note

This pull request targets release-3.1.

Cause

PluginBox.tsx used props.manifest instead of item.manifest to generate an incompatibility message. However, props.manifest is only defined while searching for plugins.

Testing plan

Note

These are the steps I've taken locally to manually check for related regressions and verify that the issue has been resolved.

  1. Set the desktop app version to 2.1.0 in packages/app-desktop/package.json.
  2. Open settings.
  3. Verify that Joplin doesn't crash.
  4. Open the "plugins" tab.
  5. Verify that most plugins are marked as incompatible:
    screenshot: Most plugins in the list marked as incompatible
  6. Search for "code".
  7. Verify that most plugins are marked as incompatible.

@personalizedrefrigerator personalizedrefrigerator changed the title Desktop: Fix fatal error on opening settings when an incompatible plugin is installed Desktop: Fix error screen shown on opening settings when an incompatible plugin is installed Oct 17, 2024
@personalizedrefrigerator personalizedrefrigerator added plugins Anything related to Joplin's plugin system v3.1 labels Oct 17, 2024
@angaba92
Copy link

angaba92 commented Oct 17, 2024

I guess this is a silly question so I apologise in the first place.
How can I do the 1st step? Set the desktop app version to 2.1.0 in packages/app-desktop/package.json.
Do I guess this is a windows route? I am using macOS

@personalizedrefrigerator
Copy link
Collaborator Author

How can I do the 1st step? Set the desktop app version to 2.1.0 in packages/app-desktop/package.json.
Do I guess this is a windows route? I am using macOS

The steps above are the manual testing plan — what I did locally to be confident that this change doesn't cause existing code to break.

If you're encountering the error fixed by this pull request, a workaround might be to uninstall all plugins by clearing the plugins directory.

To do this:

  1. Switch to Joplin's default profile (File > Switch profile).
  2. Navigate to Help > Open profile directory
  3. Open the "plugins" directory.
  4. Delete the plugins in this directory (.jpl files) or move them to a different directory.
    • Be careful doing this! This will uninstall all previously installed plugins.
  5. Restart Joplin.

@laurent22 laurent22 merged commit efb58c5 into laurent22:release-3.1 Oct 17, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugins Anything related to Joplin's plugin system v3.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants