-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Desktop: Fix errors found by automated accessibility testing #11246
Merged
laurent22
merged 18 commits into
laurent22:dev
from
personalizedrefrigerator:pr/desktop/automated-accessibility-testing
Nov 9, 2024
Merged
Desktop: Fix errors found by automated accessibility testing #11246
laurent22
merged 18 commits into
laurent22:dev
from
personalizedrefrigerator:pr/desktop/automated-accessibility-testing
Nov 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
personalizedrefrigerator
added
desktop
All desktop platforms
accessibility
Related to accessibility
labels
Oct 23, 2024
CI errrors in this CI run should be fixed by #11224. |
Conflict on styles/index.scss |
…op/automated-accessibility-testing
…d-accessibility-testing' into pr/desktop/automated-accessibility-testing
The Android APK build failure should be fixed by #11294. |
Sorry, more conflicts now. Other than that it's ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request:
@axe-core/playwright
(docs).Note
This pull request includes code from #11218.
Change summary
lang
attribute onHTML
.aria-label
s:aria-hidden={true}
instead.role='main'
androle='navigation'
elements.role='navigation'
to the sidebars androle='main'
to the note editor.role='navigation'
elements are distinguishable by their differentaria-label
s.aria-details={id}
sometimes points to an ID that isn't in the document.aria-setsize
on unsupported element.aria-setsize
from the note list and sidebar content containers. (aria-setsize
is already correctly present on children of the sidebar and note list).aria-label
to the note viewer.aria-label
to the Markdown editor's content.colorFaded
andcolor3
darker in the light theme.Additionally, while running tests in dark mode (currently disabled because of contrast issues not included below):