Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fixes #11313: Don't completely left-align the editor with the toolbar #11316

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Nov 5, 2024

Summary

This pull request adjusts the fix for #11279 — completely removing left-edge padding from the editor caused the cursor to be invisible when at the start of the line.

Fixes #11313.

Note

This pull request targets release-3.1

Note

Until this is merged, a temporary workaround might be: In settings > appearance, set "editor maximum width" to a number smaller than the Markdown editor's width.

Screen recordings

  1. Dark mode, multiple cursors at the beginning and end of lines

    Screencast.from.2024-11-05.08-32-57.webm
  2. Switching from dark mode to light mode, single cursor at the beginning of a line

Screencast.from.2024-11-05.08-36-28.webm

Screenshots

Note: All screenshots are from Fedora 41 Linux/GNOME.

Cursor at the beginning of a line in a code block

screenshot: Cursor at the beginning of a code block line

Cursor at the beginning of a paragraph line

screenshot: Cursor at the beginning of a paragraph line

Cursor at the end of a paragraph

screenshot: Shows the cursor at the end of a paragraph

@personalizedrefrigerator personalizedrefrigerator changed the title Desktop: Fixes #11313: Don't left-align the editor with the toolbar Desktop: Fixes #11313: Don't completely left-align the editor with the toolbar Nov 5, 2024
@laurent22 laurent22 merged commit cbe5505 into laurent22:release-3.1 Nov 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants