Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fix PDF export fails with error #11390

Merged

Conversation

personalizedrefrigerator
Copy link
Collaborator

Summary

This pull request fixes a regression in v3.2.1 — the exportPdf command fails with an error. The issue was originally reported on the Joplin forum.

The bug was introduced in #11181, when printTo_ was renamed to printTo, as it was no longer a private method of a class.

Testing plan

  1. Open a note.
  2. Open the go to anything dialog.
  3. Run :exportPdf.
  4. Save the PDF to a file.
  5. Attach the PDF to a note.
  6. Verify that it renders.

This has been tested successfully on Fedora 41.

@personalizedrefrigerator personalizedrefrigerator changed the title Desktop: Fix exportPdf command Desktop: Fix PDF export fails with error Nov 14, 2024
@laurent22 laurent22 merged commit 9a5842c into laurent22:dev Nov 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants