Desktop: Fixes #11405: Reduce application size by removing unnecessary Rust files

[pedr]

Fixes #11405

Summary

After the inclusion of the onenote-converter package to the project, the release build had a 100MB+ increase in size.

Format	3.2.1	3.2.3
AppImage	238 MB	369 MB
dmg	232 MB	367 MB
exe	340 MB	527 MB

This PR addresses that by removing the target folder used by Rust to store build and was being imported to the application bundle.

After this PR:

Format	3.2.1	3.2.3	This PR
AppImage	238 MB	369 MB	270 MB

Further work:

The biggest contributors to the size are:

It seems like the packages are duplicated, for example @joplin/renderer requires mermaid, but @joplin/lib by requiring @joplin/renderer also has mermaid inside of it.

Not sure how much work, but I think we might be able to cut down some MBs with a way to remove duplication when they happen. (maybe this already happen on the executable and it is only visible when the asar is unpacked??)

Testing

1. Run git clean -dfx on project root
2. Run yarn
3. Run cd packages/onenote-converter && IS_CONTINUOUS_INTEGRATION=1 yarn build
4. Run cd ../app-desktop
5. Run yarn dist
6. Run ls -lah dist/
7. Check size of the executable
8. Run ./dist/Joplin-3.2.3.AppImage and make sure it is working

[laurent22]

Thanks Pedro, so what is causing this 30 MB increase in size?

[pedr]

Thanks Pedro, so what is causing this 30 MB increase in size?

I'm going to build the two versions and see why the difference is appearing.

[pedr]

Thanks Pedro, so what is causing this 30 MB increase in size?

When comparing the two AppImages unpacked, the biggest change has been on @joplin/renderer which increased its size from 100MB to 152MB, from that being 36MB from mermaid library and 9.2MB from cytoscape-fcose (which is a new dependency of mermaid).

Note that these sizes are before packaging so that they are so high. Comparing node_modules of @joplin/renderer I got:

Details

Biggest packages on @joplin/renderer					Biggest packages on @joplin/renderer
408K	./d3-geo				332K	./uuid
412K	./d3-sankey				352K	./d3-format
416K	./@Chevrotain				368K	./dagre-d3-es
420K	./d3-contour				376K	./micromark-core-commonmark
428K	./layout-base				384K	./d3-shape
480K	./khroma				392K	./iconv-lite
512K	./acorn				408K	./d3-geo
724K	./markdown-it				412K	./d3-sankey
728K	./dompurify				420K	./d3-contour
828K	./@iconify				428K	./layout-base
1,1M	./marked				464K	./diff
1,2M	./d3				472K	./khroma
1,7M	./dayjs				700K	./dompurify
1,8M	./chevrotain				724K	./markdown-it
2,7M	./lodash-es				1,2M	./d3
4,1M	./langium				1,7M	./dayjs
4,3M	./katex				2,7M	./lodash-es
4,9M	./cytoscape				4,3M	./katex
4,9M	./@mermaid-js				4,9M	./cytoscape
9,1M	./highlight.js				7,7M	./elkjs
9,2M	./cytoscape-fcose				9,1M	./highlight.js
23M	./@joplin				23M	./@joplin
64M	./mermaid				28M	./mermaid
148M	.				96M	.

I'm not sure how easy it will be to understand, but when I was investigating I saved some logs to compare again:
size differences.ods

[laurent22]

This needs to be updated