Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fixes #11485: Fix pressing enter during composition in the title input moves focus #11491

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Dec 11, 2024

Summary

Previously, if enter was pressed while in composition mode, focus moved from the title to the note body. This was problematic in the case that enter was used to select a character during composition.

Fixes #11485.

Testing plan

MacOS Sequoia:

  1. Set up a composition method.
    • I enabled "Japanese - Romaji" in keyboard settings.
  2. Focus the title input.
  3. Start composing.
  4. Press enter.
  5. Verify that the title input is still focused.
  6. Exit composition mode.
  7. Press enter.
  8. Verify that the note body is focused.

@personalizedrefrigerator
Copy link
Collaborator Author

personalizedrefrigerator commented Dec 11, 2024

I'm closing this temporarily — I can't reproduce the issue if I run the "Testing plan" steps above before applying this change.

Edit: Although I was unable to reproduce this on Linux (Fedora 41/GNOME), I was able to reproduce this on MacOS Sequoia with the Japanese (Romaji) input method. I've updated the "Testing plan" and am re-opening this pull request.

@laurent22 laurent22 merged commit 421edb6 into laurent22:dev Dec 12, 2024
14 checks passed
@Rolograaf
Copy link

There is also a regression that Ctrl-L, Ctrl-F does not give focus on the search bar, Have to Ctrl-L - click in editor - Ctrl-F to find on page. Is this related to this problem? It is such a habit and annoying when it does not work anymore. Would imagine that Ctrl_F would be a global shortcut to search-menu at the bottom of the screen?

@personalizedrefrigerator
Copy link
Collaborator Author

There is also a regression that Ctrl-L, Ctrl-F does not give focus on the search bar, Have to Ctrl-L - click in editor - Ctrl-F to find on page. Is this related to this problem? It is such a habit and annoying when it does not work anymore. Would imagine that Ctrl_F would be a global shortcut to search-menu at the bottom of the screen?

I think this would be a separate issue.

I haven't been able to reproduce this in Joplin 3.2.5 with the default editor and all plugins disabled. I'm testing by:

  1. Starting with the Markdown editor in split screen mode.
  2. Focusing the editor.
  3. Pressing ctrl-l
    • This hides the viewer.
  4. Pressing ctrl-f
    • This opens the search dialog.
  5. Typing "test".
  6. Closing the search dialog by pressing escape.
  7. Repeating steps 3-5.
screen recording
Screencast.from.2024-12-19.09-40-06.webm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pressing decision while entering a title in multibyte removes focus from the title. Can this be improved?
3 participants