Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fixes #11508: Upgrade electron-builder and @electron/rebuild #11512

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Dec 13, 2024

Summary

This pull request upgrades electron-builder and @electron/rebuild (a dependency of electron-builder). This seems to fix #11508 and #11142.

This pull request was originally marked as a draft due to rendering issues on Windows. However, these seem related to VirtualBox's 3D acceleration settings and also happened in Microsoft Edge. Disabling 3D acceleration seems to have fixed the rendering issues.

[!IMPORTANT]

This pull request is currently a draft for three reasons:

  1. This pull request upgrades to an alpha version of electron-builder (v26) from v24 due to issues with symlinks in dependencies in v25 that prevented the app from building.
    • It may be safer to patch electron-builder.
  2. There are rendering issues when running the portable app (and occasionally, when running the nonportable app) — iframes and secondary windows render correctly, but the main frame does not:
    screenshot: Main window is pixelated
    My Windows 11 tests so far have been in VirtualBox. I've noticed a similar issue in Microsoft Edge, so I suspect that the rendering issues are specific to VirtualBox/Windows. However, I hope to confirm this before marking this pull request as ready for review.
    • Resolved: Disabling VirtualBox 3D acceleration fixed the issue.
  3. Testing on Linux and MacOS still needs to be done.
    • Resolved. See testing below.

Testing plan

On Windows 11:

  1. Build Joplin Setup 3.2.4.exe with yarn dist from packages/app-desktop.
  2. Run Joplin Setup 3.2.4.exe.
  3. Install Joplin for the current user.
  4. While Joplin is running, re-run Joplin Setup 3.2.4.exe.
  5. Wait for the "Joplin is running. \ Click OK to close it." dialog.
  6. Click "OK".
  7. Verify that Joplin closes.
  8. Wait for Joplin to install.
  9. Leave "Run Joplin" checked.
  10. Click "Finish".
  11. Verify that Joplin starts successfully.
  12. Add a task and set a reminder in the near future.
  13. Wait and verify that a notification is shown.
  14. Quit Joplin.
  15. Launch JoplinPortable.exe.
  16. Verify that the portable app starts successfully.
    • Note: The first and second times I launched the portable app, the desktop app had a mostly blank screen. The third time, the app launched successfully.

On Fedora 41:

  1. Build the Joplin AppImage using yarn dist.
  2. Verify that the AppImage starts and that both the note editor and viewer are visible.

On MacOS Sequoia:

  1. Build and install the .dmg file.
  2. Start Joplin.
  3. Verify that Joplin starts and that the editor and viewer are visible.

@personalizedrefrigerator personalizedrefrigerator marked this pull request as draft December 13, 2024 23:32
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch was previously unused. The patch was for app-builder-lib v24.4, while Joplin used v24.13.3.

@personalizedrefrigerator personalizedrefrigerator marked this pull request as ready for review December 16, 2024 15:32
@laurent22 laurent22 merged commit ac28d31 into laurent22:dev Dec 17, 2024
7 checks passed
personalizedrefrigerator added a commit to personalizedrefrigerator/joplin that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot install Joplin 3.2 on Windows
2 participants