Desktop: Fixes #11508: Upgrade electron-builder
and @electron/rebuild
#11512
+270
−182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request upgrades
electron-builder
and@electron/rebuild
(a dependency ofelectron-builder
). This seems to fix #11508 and #11142.This pull request was originally marked as a draft due to rendering issues on Windows. However, these seem related to VirtualBox's 3D acceleration settings and also happened in Microsoft Edge. Disabling 3D acceleration seems to have fixed the rendering issues.
Testing plan
On Windows 11:
Joplin Setup 3.2.4.exe
withyarn dist
frompackages/app-desktop
.electron-builder
(before the upgrade).Joplin Setup 3.2.4.exe
.Joplin Setup 3.2.4.exe
.JoplinPortable.exe
.On Fedora 41:
yarn dist
.On MacOS Sequoia:
.dmg
file.