Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Accessibility: Improve sidemenu notebook list accessibility #11556

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

Mobile: Accessibility: Improve sidemenu notebook list accessibility #11556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3384f21
Mobile: Fix folder toggle and right-click accessibility
personalizedrefrigerator Dec 21, 2024
86b918b
Fix missing key warning, remove commented out code
personalizedrefrigerator Dec 23, 2024
cf9a0f4
Refactoring, add additional accessibility information
personalizedrefrigerator Dec 23, 2024
21fde76
Mark the selected notebook as selected
personalizedrefrigerator Dec 23, 2024
603f905
Remove aria-selected (which doesn't seem to work on web)
personalizedrefrigerator Dec 23, 2024
3b2daf3
iOS: Fix icon before "notebooks" header is focusable
personalizedrefrigerator Dec 23, 2024
1a5c125
iOS: Fix notebooks heading not recognised as a heading
personalizedrefrigerator Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/app-mobile/components/Icon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,9 @@ const Icon: React.FC<Props> = props => {
const importantForAccessibility = accessibilityHidden ? 'no-hide-descendants' : 'yes';

const sharedProps = {
importantForAccessibility,
'aria-hidden': accessibilityHidden,
importantForAccessibility, // Android
accessibilityElementsHidden: accessibilityHidden, // iOS
'aria-hidden': accessibilityHidden, // Web
Comment on lines -37 to +39
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes an issue where the folder icon to the left of the "Notebooks" heading was accessibility focusable on iOS (with no label or description). On Android and Web, the same icon is hidden for accessibility.

accessibilityLabel: props.accessibilityLabel,
style: props.style,
allowFontScaling: props.allowFontScaling,
Expand All @@ -62,6 +63,7 @@ const Icon: React.FC<Props> = props => {
style={props.style}
aria-hidden={accessibilityHidden}
importantForAccessibility={importantForAccessibility}
accessibilityElementsHidden={accessibilityHidden}
>
{nameSuffix}
</Text>
Expand Down
Loading
Loading