Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fixes #9725: Fix warning logged when uninstalling multiple plugins #9726

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Jan 15, 2024

Summary

Fixes #9725 — previously uninstallPlugins returned a copy of the original PluginSettings with only the last deletion applied.

(Related to #9652).

Testing

This pull request contains an automated test and has also been manually tested by:

  1. Installing three plugins
  2. Restarting Joplin
  3. Uninstalling the three plugins
  4. Checking for warnings in the development console.

@laurent22 laurent22 merged commit d8d0e70 into laurent22:dev Jan 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting multiple plugins at once leads to "deleted outside of Joplin" warnings
2 participants