Desktop: Fixes #9953, #9948: Rich text editor: Fix context menu not shown in some cases #9954
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The logic for showing a context menu in the rich text editor was incorrect in two cases:
This is fixed by adjusting the logic that accounts for the page's current zoom and using
document.elementFromPoint
.Fixes #9953 and #9948.
Testing
This has been tested successfully on Ubuntu 23.10.
Screencast.from.2024-02-16.13-54-24.webm