Desktop: Beta editor plugin API: Fix plugins unable to require nodeJS modules #9968
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where plugins like Enhancement failed to load in the CodeMirror 6 editor because
require
failed to import modules likepath
.Note that Webpack preserves NodeJS modules
require
d from content scripts with our current Webpack configuration.Testing
This has been tested successfully by:
.jpl
file to verify that it does includerequire('path')
.test:
followed by a path was logged to Joplin's development tools.This has been tested successfully on Ubuntu 23.10.