Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify all request timeouts #33

Merged
merged 1 commit into from
Sep 1, 2023
Merged

specify all request timeouts #33

merged 1 commit into from
Sep 1, 2023

Conversation

topi314
Copy link
Member

@topi314 topi314 commented Aug 28, 2023

it seems like not specifying ConnectionRequestTimeout & SocketTimeout can cause issues where requests don't correctly timeout

Discord Help Post https://discord.com/channels/1082302532421943407/1142094131586416711

@topi314 topi314 added the bugfix label Aug 28, 2023
@topi314 topi314 self-assigned this Aug 28, 2023
@topi314 topi314 requested a review from a team August 28, 2023 10:12
@topi314 topi314 added the v2 lavaplayer v2 label Sep 1, 2023
@topi314 topi314 merged commit 12771e1 into main Sep 1, 2023
1 check passed
@topi314 topi314 deleted the patch/http-timeouts branch September 6, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix v2 lavaplayer v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant