Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stream preview thumbnail instead of channel icon #47

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

duncte123
Copy link
Contributor

@duncte123 duncte123 commented Nov 27, 2023

This replaces the profile image with the actual stream preview so it conforms to what twitch has as thumbnails

before: https://static-cdn.jtvnw.net/jtv_user_pictures/21df6206-6be7-4a70-937d-e4853b99c475-profile_image-300x300.png

After: https://static-cdn.jtvnw.net/previews-ttv/live_user_esamarathon-440x248.jpg

@topi314 topi314 requested a review from a team November 27, 2023 07:56
@topi314 topi314 added the enhancement New feature or request label Nov 27, 2023
Copy link
Member

@devoxin devoxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Has this been tested across a variety of streams to ensure that the URL remains valid?

@duncte123
Copy link
Contributor Author

Looks fine to me. Has this been tested across a variety of streams to ensure that the URL remains valid?

Yup, tested about 20 channels from the homepage.

@topi314 topi314 merged commit f2fd260 into lavalink-devs:main Nov 27, 2023
@duncte123 duncte123 deleted the fix/twitch-thumbnail branch November 28, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants