Fix Target host is not specified with HLS relative urls in m3u8 playlists
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to rectify an issue within HLS parsing where relative URLs are not converted to an absolute URL, causing a
Target host is not specifiederror message due to missing first part of the URL (thus, Lavaplayer doesn't know where to connect to, to grab the next segments in the playlist).This has only been tested with https://hls-01-radiorecord.hostingradio.ru/record/112/playlist.m3u8.
I would advise further testing, including URLs from playlists containing absolute URLs to ensure backwards compatibility. I've tried to ensure this won't affect previously supported URLs however more testing is always welcome, as well as any general feedback.